CodeIgniter4 icon indicating copy to clipboard operation
CodeIgniter4 copied to clipboard
verified publisher icon codeigniter4

fix: Entity can't handle column named attributes

Open kenjis opened this issue 3 years ago • 3 comments

Description Fixes #5762 Supersede #5763

  • fix Entity can't handle column named attributes
  • add new setter method "_set + key" for a attribute

Checklist:

  • [x] Securely signed commits
  • [x] Component(s) with PHPDoc blocks, only if necessary or adds value
  • [ ] Unit testing, with >80% coverage
  • [ ] User guide updated
  • [x] Conforms to style guide

kenjis avatar Mar 07 '22 02:03 kenjis

I like this solution better, but let's wrap up the Issue conversation first. I think it is quite possible that someone is using $entity->attributes = $_POST not realizing the current behavior is "unintended".

MGatner avatar Mar 13 '22 12:03 MGatner

Maybe mark this one to revisit for version 5?

MGatner avatar Mar 18 '22 11:03 MGatner

Added a note: https://github.com/codeigniter4/CodeIgniter4/projects/6#card-79354180

kenjis avatar Mar 18 '22 22:03 kenjis