CodeIgniter4 icon indicating copy to clipboard operation
CodeIgniter4 copied to clipboard
verified publisher icon codeigniter4

fix: rename Entity::setAttributes() to avoid name collision

Open kenjis opened this issue 3 years ago • 2 comments

Description Fixes #5762

Checklist:

  • [x] Securely signed commits
  • [] Component(s) with PHPDoc blocks, only if necessary or adds value
  • [ ] Unit testing, with >80% coverage
  • [ ] User guide updated
  • [x] Conforms to style guide

kenjis avatar Mar 03 '22 04:03 kenjis

@kenjis Is this still relevant after #5809?

MGatner avatar Sep 16 '22 10:09 MGatner

At least, this PR won't be merged into 4.x. But I want to fix this bad design in the future.

kenjis avatar Sep 17 '22 00:09 kenjis

I like the injectRawData naming. It can be merged into 4.x if setAttributes is still kept as deprecated so that we can upgrade before the next major version.

najdanovicivan avatar Jan 27 '23 08:01 najdanovicivan

I sent PR #7208

kenjis avatar Feb 01 '23 05:02 kenjis