CodeIgniter4 icon indicating copy to clipboard operation
CodeIgniter4 copied to clipboard

Refactor BaseBuilder.php and fix xxxBatch() methods docs

Open kenjis opened this issue 4 years ago • 1 comments

Description

  • refactor variable name in system/Database/BaseBuilder.php
  • fix insertBatch() / updateBatch() / setUpdateBatch() user guide
  • add tests for insertBatch() / updateBatch() with array of objects param

insertBatch() updateBatch() the first param

The User Guide says "You can either pass an array or an object to the function." But the the first param type is ?array in the code.

In fact, you can pass an array of arrays or objects.

Checklist:

  • [x] Securely signed commits
  • [ ] Component(s) with PHPdocs
  • [ ] Unit testing, with >80% coverage
  • [x] User guide updated
  • [x] Conforms to style guide

kenjis avatar Sep 28 '21 02:09 kenjis

Related #5149

kenjis avatar Oct 02 '21 01:10 kenjis

Can this be closed now?

sclubricants avatar Oct 24 '22 00:10 sclubricants

Is there test case for array of objects now?

kenjis avatar Oct 24 '22 01:10 kenjis

Is there test case for array of objects now?

UpsertTest::testUpsertAndUpsertBatchWithObject()

sclubricants avatar Oct 24 '22 18:10 sclubricants

Thank you!

kenjis avatar Oct 24 '22 21:10 kenjis