Bug: [QueryBuilder] BaseBuilder::compileFinalQuery() has hard coded Query class

Open kenjis opened this issue 4 years ago • 0 comments

Describe the bug This may be not a bug. But Query class may be DBMS-specific, it is better not to hard code Query class. https://github.com/codeigniter4/CodeIgniter4/blob/42f6667b6a56994ba3f41d12a20738a695bfa055/system/Database/BaseBuilder.php#L1850

See https://github.com/codeigniter4/CodeIgniter4/pull/4176#issuecomment-782771219 and https://github.com/codeigniter4/CodeIgniter4/pull/4176#issuecomment-782772913.

CodeIgniter 4 version develop branch.

Affected module(s) Database

Expected behavior, and steps to reproduce if appropriate The DBMS-specific Query class is used.

Feb 24 '21 02:02 kenjis