CodeIgniter4
CodeIgniter4 copied to clipboard
codeigniter4
WIP Refactor Email
Rework the Email package to be consistent with the other CI4 packages - exceptions, email vs Transporter, unit testing. Being worked on in feature/email branch.
@jim-parry Will this be ready for RC1? We need to ship some form of email with the framework.
At one point I had ported over the CI3 version, but it looks like it's no longer there?
I will prioritize email.
When I started in on unit testing for what had been ported over, I concluded that it was a can of worms, and needed refactoring not just testing. The old one was removed some time ago.
When are you thinking we should shoot for RC1?
It will take a few days at elast to finish this off.
Jim Parry Faculty, Computer Systems Project Lead, CodeIgniterhttps://codeigniter.com
From: Lonnie Ezell [email protected] Sent: Sunday, May 12, 2019 8:26 PM To: codeigniter4/CodeIgniter4 Cc: James Parry; Mention Subject: Re: [codeigniter4/CodeIgniter4] Refactor Email (#1615)
@jim-parryhttps://github.com/jim-parry Will this be ready for RC1? We need to ship some form of email with the framework.
At one point I had ported over the CI3 version, but it looks like it's no longer there?
You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/codeigniter4/CodeIgniter4/issues/1615#issuecomment-491663663, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AAYOG35EBUMEOAOBV2NFBX3PVDNXJANCNFSM4GKVCHAA.
Oh, not in a huge rush for RC 1. First week of next month is a good goal, I think.
The current Email is driving me crazy. I'm shocked it made it so long in CI3 in its current state - or maybe something was lost in the port? Do we have any of the refactor that Jim started? or is that lost and we need a fresh start?
Looks like that was lost. I had hoped he had a branch here for it but don't see one. :(
Here is some work started by Jim on this: https://github.com/jim-parry/CodeIgniter4/tree/refactor/email/system/Email
https://forum.codeigniter.com/thread-73487.html
I think, at the current situation the choice is obvious. Keep the current API and the same. Keep the documentation about the API the same. And place PHPMailer behind the curtain. For CI 3 I did this for years without problems (no problems about internal encodings and about Bulgarian language).
The maintainer of PHPMailer spent years for polishing it, it is a hard burden that is unnecessary for you to take.
Edit: As far as I can remember about CI3, its Email library missed a feature - embedding an image within the message body text. So, if you want to put a logo somewhere, the original library can't help. I might be wrong, this is what I can recall.
I've started a refactor branch with Jim's work: https://github.com/codeigniter4/CodeIgniter4/tree/refactor/email
We will need to decide if this is going to replace the existing class or run alongside it (in other words, how much breaks and whether it can be a point update).
update for v4.2: Some of Jim's work was in a different direction than we've decided to take this. I incorporated much of it into a new branch that is well underway, but I need to hand it off due to time constraints.
The new branch: https://github.com/codeigniter4/CodeIgniter4/tree/feature/mailer