php-the-right-way
php-the-right-way copied to clipboard
codeguy
How to submit updated/dead links?
While (proof)reading (see #926) I also encountered a fair number of links which are changed on the remote site, and some dead ones. Here I'm not sure what would be the recommended way to submit changes, as some cases can result in discussion, and in a few cases I'm uncertain what to change for a dead link with no replacement.
Examples: http links redirecting to https; links that do currently redirect to a new path on the same site; dead links no longer redirected even though the article still exists on a new path; links redirecting to a different site; links to a path on a site where only the frontpage still works; dead links no longer found on a live site but which are available in the Wayback Machine (archive.org); links where both title and site/path were updated.
So should these all be separate PRs, or grouping related commits in multiple PRs, or...? Any advice? Preferably not resulting in an excessive amount of work. :)
Okay, not sure what kind of response times are customary in this repo, so I tried my luck with the first PR #928. Further updates are (sometimes) trickier, so I'll probably use separate PRs.
Good morning! Re: response times, we're a small group of maintainers that have day jobs. Speaking for myself, I check in a few times a week. I'm just so busy lately. So expect a few days before a reply. Maybe sooner!
Separate PRs are fine, but we're really not picky. If you are confident in the changes, just batch them together. You can always revise a PR in progress.
Different timezone here, so good afternoon. :) Thanks for the feedback, will keep plugging away on the remaining changes.
@codeguy After two+ months I was wondering... are my PRs ever going to get reviewed/merged? After these I probably have one more with leftovers, but with so much pending stuff it is a bit tricky to find them in the diffs between my working copy, and a repo copy that is still at gh-pages' head.
@Xymph I suppose this can be closed now :) not just because your PRs have been merged, but also because you've been made a collaborator and can merge PRs yourself! :D
I am aware, but wasn't quite done with everything I wanted to submit as a result from this topic, and didn't have time for this project these past few days. I also intend to look at some issues by others soon.
But meanwhile I guess this one can be closed, yeah.