Adrian Cole

Results 1423 comments of Adrian Cole

interesting and good progress. Your code made me notice that how things are called is engine-specific due to how the stacks work. We can continue with the interceptor pattern or...

oh PS you are totally right we aren't doing context correctly. having one stashed in RuntimeConfig is a sure way to have broken traces. I'll raise a PR for your...

some details to help shape things around names: * functions are only referenced by their numeric index, which is module-specific. ex an imported function will have a different number than...

#505 started this internally so we can practice a bit. Particularly, value types are changing between 1.0 and 2.0 so we need to solidify that before exporting the hooks

Plan to expose this in #513 though the interface I think should change to a more intercepter vs event listener (for function lifecycle). We may also do an event listener...

I think listener can be done in JIT and possibly we can make a special call-out for an interceptor. In any case I think listener is the wrong design to...

PS I'll be more specific on the issues, though added some to the PR that makes things playable in interpreter for now. The main thing is JIT code is running...

The TL;DR; of above is I think the current design is a good toehold for a future design that supports the interceptor use case and also reduces the surface area...

implementing this would be best done via a `HostModule` type because we currently enforce host modules once setup are immutable. This means we can't later add other things to them...

step 1: https://github.com/tetratelabs/wazero/pull/280