Adrian Cole
Adrian Cole
arm build is failing for some reason. it doesn't print out the "awaiting ML jobs" part, which is maybe a smoking gun ``` /usr/local/lib/python3.12/site-packages/opentelemetry/instrumentation/elasticsearch/__init__.py:213: Warning: Instrumentation disabled, relying on elasticsearch...
I think this is really still a UX win for normal otel stuff vs having to explicitly add env vars like this: ``` # Phoenix does not support OTLP metrics...
@arkodg tl;dr; on this branch. I'm resolving a TODO to support Mix of text (body in otel) and json (attrs in otel) in order to support structured log exports. The...
@arkodg @zirain any suggestions on this? It is the last essential part of the dependencies of #7674 and allows otel to work properly wrt access logs. Again, I chose the...
@zirain I think I got the tests desired. lemme know if not
ok made a revision also to PR desc to hopefully answer questions in comments. I will revisit this again monday if there is more feedback.
pulling into draft while I remove the port dodging things for things we can't control yet.
also I just realized we never added this for tracing either, so will add that to the PR
ok I updated this as I noticed the same thing was missing everywhere, in logs metrics and tracing. fixed so that the tests are coherent and we don't need to...
@arkodg @zirain I will mark this draft again and rebase after #7695 is merged because without those changes, the integration test for headers here won't pass.