Adrian Cole

I'm wondering what the rationale is for a separate branch for master-java8, as that introduces a lot of maintenance. Should we not compile to java8 with JDK11 instead? Basically drop...

probably the best way to move this forward is to test it, try to reproduce with docker, as this repo doesn't have a helm chart. e.g. https://github.com/openzipkin/zipkin-dependencies/tree/master/docker#cron

fyi https://github.com/openzipkin/zipkin-helm/pull/11 is the currently dormant effort to make this a helm chart

So, I missed the major detail on #192 which is that the solution was to change to running as root. I think basically this issue should be renamed to "don't...

sorry maybe supercronic as that's currently maintained. Basically something that does scheduling as non-root. After this is in, someone can also look at k8s native scheduling in https://github.com/openzipkin/zipkin-helm/pull/11, but I...

@reta not asking you to volunteer to action this, but do you have any idea what the gap is? I know you don't work on AWS stuff, just in case...

so I think that in the distant past ES_WAN_ONLY maybe was used for elasticsearch on aws and affected here https://github.com/openzipkin/zipkin-dependencies/issues/45 Some sort of code change here might need to be...

@SamTV12345 sorry should have clarified, this is for the service dependency graph aggregated from trace data collected into zipkin. This isn't about the library dependency tree of the project build,...

ps happy to add integration tests if this feels helpful. cc @spencergibb @wind57 @ryanjbaxter as I feel with this log detail, it is a lot easier to reason with the...

Thanks for the review @brendandburns. In analyzing how to propagate a "trace logging" flag, it seems the most sensible place to instrument is ReflectorRunnable where all the other logging is...