Adrian Cole

Results 2042 comments of Adrian Cole

depends on what you mean by "I guess we could drop the output to Zipkin" If I were you, I would check the issues list in case folks have asked...

there's a semantic release pending (1.27.0) and big q on my mind is if this is blocking the release or not? For me, I'm not a maintainer so can't make...

suggestion: "Introduce per-message structured GenAI events" -> "Change prompt-completion recording from span events to log events"

also lacking this, tinygo hack wasmtime to mount pre-opens named ".." "../.." etc to let paths resolve relative the working directory https://github.com/tinygo-org/tinygo/blob/9027c50405b13ca48859bc82c660840140621ed5/main.go#L289

I agree that open [0-255] is more pragmatic, though not sure if anyone is taking advantage of the value type allowing larger values. In any case, open avoids a false...

https://github.com/WebAssembly/wasi-clocks/blob/958c1a1c08f489e0c5dc83dd87c444e014a8bf0f/README.md?plain=1#L55-L56 needs to be clarified, particularly it seems a goal to provide TZ data (I might be wrong). Knowing if defaulting the TZ is still a non-goal is helpful.

for wazero, we are going with clock as it is `clock_time_get` not `clocks_time_get`. whatever naming choice should lean towards function names, packages, or enclosing filenames, IMHO

I think assumptions underpinning things should be validated by a diversity of environments minimally adding windows and probably also a VM like java. I don't think we want to make...

ps the main project I work on doesn't have this problem as we save a base time off. For example, here's how we implement the monotonic clock which won't be...

> However, it will continue to be possible to make changes, up until preview2 is voted on by the WASI Subgroup. And after preview2, there will likely be a preview3,...