vscode-rpgle icon indicating copy to clipboard operation
vscode-rpgle copied to clipboard

Feature/surround with monitor action

Open sebjulliand opened this issue 2 years ago • 2 comments

Changes

Inspired by this discussion: https://github.com/orgs/halcyon-tech/discussions/1345

Added an RPGLE submenu and a Surround with monitor action for rpgle editors.

Surrounding will be allowed only for Free RPGLE code. Fixed RPG or mixed RPG will show a warning. The action will surround the code, based on:

  • The current cursor position Code_mrfBFQSxCF

  • The current selection Code_C1HBThwqtb

It's not necessary to select the entire code. The action will select the whole line(s).

Checklist

  • [x] have tested my change
  • [x] for feature PRs: PR only includes one feature enhancement.

sebjulliand avatar Jun 07 '23 20:06 sebjulliand

Pretty good feedback @worksofliam , thanks! Here's an alternative: we don't rely on /free and /end-free and try to detect if it's actually Free when the program itself is not Fully Free. What's your thought?

sebjulliand avatar Jun 26 '23 12:06 sebjulliand

@sebjulliand

This is a truly late reply, but...

Here's an alternative: we don't rely on /free and /end-free and try to detect if it's actually Free when the program itself is not Fully Free. What's your thought?

Because /FREE and /END-FREE are optional directives. We can't rely on them to detect if it's free format or not. Sad times.

worksofliam avatar Oct 13 '23 17:10 worksofliam