vscode-rpgle icon indicating copy to clipboard operation
vscode-rpgle copied to clipboard

Published 20 hours ago • verified publisher icon codefori

Show SQL cursors in outline view

Open sebCIL opened this issue 1 year ago • 10 comments

Changes

Show SQL cursors in outline view. image

I'm not sure about the icon.

Checklist

  • [X] have tested my change
  • [X] updated relevant documentation
  • [X] Remove any/all console.logs I added
  • [X] eslint is not complaining
  • [X] have added myself to the contributors' list in the README
  • [X] for feature PRs: PR only includes one feature enhancement.

sebCIL avatar Mar 06 '23 13:03 sebCIL

Sorry, after more tests, I have some bug with fixed format.

sebCIL avatar Mar 06 '23 14:03 sebCIL

@sebCIL please also write some test cases for this feature.

Thanks!

worksofliam avatar Mar 06 '23 15:03 worksofliam

@sebCIL please also write some test cases for this feature.

Thanks!

Done.

sebCIL avatar Mar 08 '23 07:03 sebCIL

@sebCIL When running these tests, I am getting an error from a test:

vscode-rpgle barry$ npm run test

> [email protected] test
> tsx tests

Running 157 tests:
/Users/barry/Repos/vscode-rpgle/tests/suite/linter.js:2429
  assert.strictEqual(errors.length, 1);
         ^

AssertionError [ERR_ASSERTION]: Expected values to be strictly equal:

3 !== 1

    at null.exports.linter34 (/Users/barry/Repos/vscode-rpgle/tests/suite/linter.js:2429:10)
    at null.run (/Users/barry/Repos/vscode-rpgle/tests/index.js:17:5) {
  generatedMessage: true,
  code: 'ERR_ASSERTION',
  actual: 3,
  expected: 1,
  operator: 'strictEqual'
}

worksofliam avatar Mar 19 '23 19:03 worksofliam

Ok, I fixed it.

sebCIL avatar Mar 20 '23 12:03 sebCIL

@chrjorgensen @sebjulliand Any chance I can get your opinion on this PR? Do you think showing the cursors is standard and would be useful to the user?

worksofliam avatar May 12 '23 15:05 worksofliam

@worksofliam I have not seen cursors in an outline view before - it's not in RDi. But to me it would be a nice addition - helping in locating the definition of a SQL cursor.

chrjorgensen avatar May 15 '23 11:05 chrjorgensen

@sebCIL Review incoming today. Thank you!

worksofliam avatar May 19 '23 18:05 worksofliam

Sorry, I didn't test my test !

sebCIL avatar May 21 '23 08:05 sebCIL

@sebCIL There is another big PR I am needing to merge ASAP. I suspect it will have a large impact on this PR. Just thought I'd give you a heads up.

worksofliam avatar Jun 15 '23 09:06 worksofliam