vscode-ibmi
vscode-ibmi copied to clipboard
Add open from IBM i functionality
Changes
Add open from IBM i functionnality.
Soves #492
Checklist
- [x] have tested my change
- [x] updated relevant documentation
- [x] Remove any/all
console.log
s I added - [x] eslint is not complaining
- [x] for feature PRs: PR only includes one feature enhancement.
@worksofliam, it's ready for you to review my answers/code changes
Much like CL prompting, perhaps we could automatically install this program and set up the PDM option.
From an old PR: https://github.com/halcyon-tech/vscode-ibmi/blob/29a824671b2660d71b1316227eb42f6d19f8e6a9/src/api/JobListener/sources/openmbr.js
Much like CL prompting, perhaps we could automatically install this program and set up the PDM option.
From an old PR: https://github.com/halcyon-tech/vscode-ibmi/blob/29a824671b2660d71b1316227eb42f6d19f8e6a9/src/api/JobListener/sources/openmbr.js
I added the create of the STRC4I command and program (same way as GENCMDXML).
The automatic creation of the PDM option is a bit problematic since the PDM user defined option file (QGPL/QAUOOPT) is customizable per user profile but there is no official way (AFAIK) to retrieve which file is used by a user (it is stored in the user profile object itself). I opted to explain in the documentation how to create the custom option.
@dferrand - this is still on my to-do list. It's a big feature and want to make sure I give it the time it deserves when I review it.
No worry @worksofliam , take your time.
Hi @dferrand - this is looking great! Before I merge this though, I will be looking into another VS Code API which may allow us to use a URL along with STRPCCMD
. See this comment: https://github.com/halcyon-tech/vscode-ibmi/issues/492#issuecomment-1061111991