vscode-ibmi icon indicating copy to clipboard operation
vscode-ibmi copied to clipboard

Published 20 hours ago • verified publisher icon codefori

Support workspace folder parameter on `runAction`

Open SanjulaGanepola opened this issue 1 year ago • 3 comments

Changes

This PR simply adds the workspaceFolder as an optional parameter on runAction. The purpose of this change is so that when runAction is used on an object or member in Project Explorer, the local project's LIBL and CURLIB variables are used.

Associated change in PE: https://github.com/IBM/vscode-ibmi-projectexplorer/pull/575

How to test this PR

  1. Actions unrelated to PE should work as before.
  2. Actions from PE should use the project's LIBL and CURLIB.

Checklist

  • [x] have tested my change

SanjulaGanepola avatar Sep 03 '24 15:09 SanjulaGanepola

Code is fine, but I think this is the last parameter we accept before changing the entire signature to use an object instead.

worksofliam avatar Sep 10 '24 14:09 worksofliam

Code is fine, but I think this is the last parameter we accept before changing the entire signature to use an object instead.

That could be a good change for v3.

sebjulliand avatar Sep 10 '24 14:09 sebjulliand

@worksofliam @sebjulliand Could we get this PR merged and released? Need it for a PE release 😃

SanjulaGanepola avatar Oct 22 '24 20:10 SanjulaGanepola