vscode-ibmi icon indicating copy to clipboard operation
vscode-ibmi copied to clipboard

Possible type in Walkthrough

Open rogersonra opened this issue 9 months ago • 4 comments

I just wanted to point out that there may be a typo in the latest Local Development with ILE Walkthrough. I think the word directory should have been command.

image

rogersonra avatar May 15 '24 13:05 rogersonra

Good spot!

Can be fixed here: https://github.com/codefori/vscode-ibmi-walkthroughs/blob/main/content/code-ibmi-local/actions-create.md

worksofliam avatar May 15 '24 13:05 worksofliam

@SJLennon, I believe you do a lot of the documentation. As I've no experience with contributing/fixing do you think we could arrange a call so you can show me how to fix this? If you don't have time or I have the wrong person please forgive me and maybe suggest someone who could walk me through how to fix this.

Thanks,

Rob

rogersonra avatar May 15 '24 14:05 rogersonra

@rogersonra This doesn't look difficult. I can do it.
But if you want to learn to do it your self that will take a bit longer.

SJLennon avatar May 15 '24 16:05 SJLennon

@SJLennon If you have time I'd love to see how you make the change. Let me know if you have time to show me the ropes. Thanks, Rob

rogersonra avatar May 15 '24 17:05 rogersonra

@rogersonra

First, see the readme for walkthroughs. Page down to the "Getting started is simple" section, and that gives you a decent start.

This change is very simple and we can make it directly on GitHub, following the above steps. (It's running VS Code in your browser--looks very similar to VS Code on your desktop.) When finished with the change it has to go from your fork back to the main project.

Commit the changes to the forked project.

image

Create a new pull request.

image

Complete the pull request.

image

And done!

You can now see the pull request on the main project:

image

If you were making more extensive changes you need to know a bit about GitHub markdown.

If I was making extensive changes I would probably clone my fork to my PC and make the changes in VS Code. You need git installed on your PC, of course.

SJLennon avatar May 18 '24 20:05 SJLennon