Cleanup/connection_manager_api

[worksofliam]

trafficstars

Changes

Replaces raw access of connections setting and password context with a ConnectionManager namespace.

How to test this PR

1. Ensure the same test cases pass
2. Try out the extension as normal
3. Confirm debug still works
4. When editing connection settings or login settings, ensure the sort button is disabled.

Checklist

• [ ] have tested my change
• [ ] have created one or more test cases
• [ ] updated relevant documentation
• [ ] Remove any/all console.logs I added
• [ ] have added myself to the contributors' list in CONTRIBUTING.md

[worksofliam]

@sebjulliand Let me look into how to solve this problem. Should have a fix for it by the end of the week. Thanks for your review!

[worksofliam]

@sebjulliand Sorry this took SO long. I went ahead and used withContext around the UI logic to disable the buttons. Check it out and let me know - thanks!

[sebjulliand]

@worksofliam I'll fix a small issue here with withContext; in the meantime, how about adding that brilliant use of it to disable the buttons and disable code-for-ibmi.connectTo, code-for-ibmi.connectToAndReload, code-for-ibmi.renameConnection, code-for-ibmi.deleteConnection as well? WDYT?

[worksofliam]

@sebjulliand Updated!