vscode-ibmi icon indicating copy to clipboard operation
vscode-ibmi copied to clipboard

The default actions `Create Service Program` and `Create Program` should not be enabled for `GLOBAL` i.e. all file extensions

Open edmundreinhardt opened this issue 1 year ago • 2 comments
trafficstars

Describe the bug After launching actions setup, the default actions for PGM and CRTSRVPGM are created as global and are therefore available for all source files. This leads to running these actions on the wrong source.

To Reproduce I just tested the action IBM i: Launch Actions Setup image

and the actions.json entry created

  {
    "extensions": [
      "GLOBAL"
    ],
    "name": "Create Service Program (CRTSRVPGM EXPORT(*ALL))",
    "command": "CRTSRVPGM SRVPGM(&CURLIB/&NAME) EXPORT(*ALL) BNDSRVPGM(*NONE) BNDDIR(*NONE) ACTGRP(*CALLER)",
    "environment": "ile"
  },

Here is the screen recording of the confusing result of this

https://github.com/IBM/vscode-ibmi-projectexplorer/assets/59372176/cbc4d226-3df8-42f0-9751-65c1e3bc5742

Expected behavior These actions should not appear for inappropriate file extensions

Environment:

  • Extension version 2.8.0
  • IBM i OS version 7.4

The issue is not unique to these versions

edmundreinhardt avatar Mar 27 '24 10:03 edmundreinhardt

What are the recommended extensions you suggest?

worksofliam avatar Mar 27 '24 14:03 worksofliam

The file extensions which are appropriate for this

  • I would expect to build SRVPGM and PGM from .bnddir source or from .ilesrvpgm and .ilepgm pseudo source But this particular action seems to take the object name as input so would it work on anything but a .PGM or .SRVPGM object. Even in this case, would it not need the binder source to be useful?

edmundreinhardt avatar Apr 16 '24 14:04 edmundreinhardt