edu-client icon indicating copy to clipboard operation
edu-client copied to clipboard

the elements of the footer are now redirecting to the respective page for …

Open Sarthak-06 opened this issue 4 years ago • 1 comments

…ex if we click instagram icon it will open a instagram page in a new tab

#406

fixes #

Describe the changes you've made I have added links to all social media icons like instagram, twitter, youtube and github. I have used react-icons. For that i installed it by adding command npm install react-icons --save then i wrapped the code within IconButton. I have deleted the code that used map and icon list to display those social media icons.

Describe if there is any unusual behavior (Any Warning) of your code(Write NA if there isn't) I also got some warning like Line 55:28: Replace ·href="https://twitter.com/codeforcauseIn?ref_src=twsrc%5Egoogle%7Ctwcamp%5Eserp%7Ctwgr%5Eauthor"·target="_blank"·aria-label="Twitter" with ␍⏎··················href="https://twitter.com/codeforcauseIn?ref_src=twsrc%5Egoogle%7Ctwcamp%5Eserp%7Ctwgr%5Eauthor"␍⏎··················target="_blank"␍⏎··················aria-label="Twitter"␍⏎················

Additional context (OPTIONAL)

Test plan (OPTIONAL)

A good test plan should give instructions that someone else can easily follow.

Checklist

  • [x] My code follows the code style of this project.
  • [ ] My change requires a change to the documentation.
  • [ ] I have updated the documentation accordingly.
  • [x] All new and existing tests passed.
  • [x] The title of my pull request is a short description of the requested changes.

Provide a Deployed link of route/page that needs to review Preview: Deploy preview link here with the appropriate route

Sarthak-06 avatar Sep 16 '21 20:09 Sarthak-06

@Sarthak-06 Please provide a screenshot of the footer.

Abhishek-kumar09 avatar Oct 02 '21 12:10 Abhishek-kumar09