edu-client icon indicating copy to clipboard operation
edu-client copied to clipboard

Fix: profile ui improvements

Open rajatgupta24 opened this issue 3 years ago • 5 comments

Issue Number

fixes # UI Improvements in profile section

  • Center aligned the activity, achievement bar
  • Decrease the height of cards in mobile view
  • Replace the "view" with ">"

Describe the changes you've made

Describe if there is any unusual behavior (Any Warning) of your code(Write NA if there isn't)

Additional context (OPTIONAL)

Test plan (OPTIONAL)

A good test plan should give instructions that someone else can easily follow.

Checklist

  • [ ] My code follows the code style of this project.
  • [ ] My change requires a change to the documentation.
  • [ ] I have updated the documentation accordingly.
  • [ ] All new and existing tests passed.
  • [ ] The title of my pull request is a short description of the requested changes.

Provide a Deployed link of route/page that needs to review Preview: Deploy preview link here with the appropriate route

rajatgupta24 avatar Jun 28 '21 18:06 rajatgupta24

Please review @adarsh-technocrat

Abhishek-kumar09 avatar Jul 01 '21 16:07 Abhishek-kumar09

Please review @adarsh-technocrat

Sure @Abhishek-kumar09 :)

adarsh-technocrat avatar Jul 01 '21 16:07 adarsh-technocrat

@adarsh-technocrat I mistakenly reviewed it too 😅 I don't know that you already reviewed this, maybe I was typing that time sorry my bad :(

Abhijay007 avatar Jul 01 '21 18:07 Abhijay007

Hey @adarsh-technocrat, I made the changes, & centered the achievement tabs at tablet view (still scrollable).

And the changes in package & package-lock.json are because I ran npm audit fix.

rajatgupta24 avatar Jul 03 '21 18:07 rajatgupta24

Desktop View

image Tablet View

image Mobile View

image

rajatgupta24 avatar Jul 03 '21 18:07 rajatgupta24