edu-client icon indicating copy to clipboard operation
edu-client copied to clipboard

Removed video-react and replaced it with React Player

Open rizwan2000rm opened this issue 3 years ago • 10 comments

Issue Number

fixes #149

Describe the changes you've made

Replaced video-react with react-player. Uninstalled video-react package from the project.

rizwan2000rm avatar Mar 29 '21 04:03 rizwan2000rm

Please Remove merge conflicts

Abhishek-kumar09 avatar Apr 02 '21 11:04 Abhishek-kumar09

@Abhishek-kumar09 Done. I have integrated the changes according to new folder structure.

rizwan2000rm avatar Apr 03 '21 13:04 rizwan2000rm

Thanks @rizwan2000rm This is halted for some time, though it counts in your contribution. I have halted it to check som more things which I could not check it now.

You can carry on to other PRs, I will get back to this after some time, and then we will do the required changes if any together.

Abhishek-kumar09 avatar Apr 03 '21 18:04 Abhishek-kumar09

@Abhishek-kumar09 Sure. No problem.

rizwan2000rm avatar Apr 03 '21 21:04 rizwan2000rm

@rizwan2000rm resolve merge conflicts. pull upstream changes for that :)

Abhijay007 avatar May 20 '21 13:05 Abhijay007

@Abhijay007 This PR is halted for detailed review from @Abhishek-kumar09

rizwan2000rm avatar May 23 '21 13:05 rizwan2000rm

If this has to be tested now let me know I will fix the conflicts soon @Abhijay007 @Abhishek-kumar09

rizwan2000rm avatar May 23 '21 13:05 rizwan2000rm

Will update you on this.

Abhishek-kumar09 avatar May 25 '21 12:05 Abhishek-kumar09

@rizwan2000rm I think that this change will get covered In this PR (#367) you can close this PR if you want :)

Abhijay007 avatar Jun 25 '21 18:06 Abhijay007

No please keep it open. It's a good reference and thanks @rizwan2000rm for this PR

Abhishek-kumar09 avatar Jun 25 '21 18:06 Abhishek-kumar09