causefolio icon indicating copy to clipboard operation
causefolio copied to clipboard

Added `Lint Action` GitHub action

Open zeborg opened this issue 3 years ago • 4 comments

Description

Added Lint Action GitHub action with Prettier integration to lint and autofix code styling issues.

Related Issue

Fixes #81

Type of Change:

  • New Feature

How Has This Been Tested?

Tested on my forked repository.

Checklist:

  • [x] Pull request is made against development branch.
  • [x] My code follows the style guidelines of this project.
  • [x] I have performed a self-review of my own code.
  • [x] My changes generate no new warnings

zeborg avatar Jun 14 '21 05:06 zeborg

I guess I need someone to make a dummy PR to my forked repo in order to test if it's gonna be functional once it's merged into the upstream.

@mdPial I hope you won't mind assisting me here 🙏

zeborg avatar Jun 14 '21 05:06 zeborg

Yes. Of course. It will be delightful. But you can make your own PR in your forked repo. Make a duplicate of this branch locally then add/make some code with ESLint problems and push it. causefolio will be selected as a head repo by default, select your own forked repo from the drop-down, and create a pull request. image It will create PR in your forked repo then. I am a little busy with other things right now. If you unable to do that I will make a PR in your forked repo.

piall avatar Jun 14 '21 14:06 piall

@mdPial I've been doing the exact same thing since yesterday during my testing and it was working well all the time, but once I made the PR here it failed.

I've read about the error that's being shown here, and it's somehow related to the permissions provided by the GitHub token which I couldn't grasp that well, so I felt like maybe it worked for me because I was the owner of the repo itself with all the permissions to it.

But thanks, I'll try some other way to figure it out!

zeborg avatar Jun 14 '21 15:06 zeborg

@zeborg Yes. Because of that reason failing. I had also faced the same issue while working for another repo. After lots of trial and error, I had found this action. Which didn't have any permission related issues.

piall avatar Jun 14 '21 15:06 piall