archive.codeforcause.org icon indicating copy to clipboard operation
archive.codeforcause.org copied to clipboard

Remove all the unused dependencies which are nowhere used

Open idontknowjs opened this issue 5 years ago • 7 comments

There are many dependencies like "react-quill", "formik", "immutable", "react-draft-wysiwyg" and many more...

image

idontknowjs avatar Nov 09 '20 18:11 idontknowjs

Thanks @covalentbond for raising this detailed issue.

react-quill", "formik", "immutable", "react-draft-wysiwyg"

Ya, they are used no where.

For the image - These all are unused, but the similar ones are used within the code, Please assure that the code functionality is not compromised by removing them.

Abhishek-kumar09 avatar Nov 10 '20 11:11 Abhishek-kumar09

Those which are shown in the image have not been imported anywhere in the code. The image is a result of a library "depcheck" which shows the unused dependencies.

But it cannot be completely correct, as it showed "keycloak-js" as one of the unused dependencies as it's not imported. But "keycloack-js" is also not imported but actually used in one of the files.

The only way to this is checking manually each of the dependencies, whether it has been used anywhere in the project or not. There might be even more which are not stated above

idontknowjs avatar Nov 10 '20 12:11 idontknowjs

Hello, there @Abhishek-kumar09 @covalentbond , is this issue still open? Because I'd love to work on this issue and resolve it.

Itsaadarsh avatar Jan 12 '21 05:01 Itsaadarsh

@Itsaadarsh It's open. But would you help in removing some console errors from the website first. This way you could learn more about codebase, and they are pretty easy too. You could remove few of them and make a PR. https://github.com/codeforcauseorg/codeforcause.org/issues/92

Abhishek-kumar09 avatar Jan 12 '21 07:01 Abhishek-kumar09

Always feel free to tag me, as sometimes conversations are missed, and the fault is totally mine.

Abhishek-kumar09 avatar Jan 12 '21 07:01 Abhishek-kumar09

Yes sure thing @Abhishek-kumar09 , but first I'll send (#152) PR then I'll move towards the next. Because I'm done removing all the unused dependencies, I'll clean up a little and send the PR asap.

Itsaadarsh avatar Jan 12 '21 09:01 Itsaadarsh

Great! thanks.

Abhishek-kumar09 avatar Jan 12 '21 13:01 Abhishek-kumar09