archive.codeforcause.org icon indicating copy to clipboard operation
archive.codeforcause.org copied to clipboard

[Feature request] dark mode

Open haaarshsingh opened this issue 5 years ago • 13 comments

Add a simple setting which makes the website go light, or dark, for the creatures of the night.

haaarshsingh avatar Oct 27 '20 00:10 haaarshsingh

Fantastic one! We thought of it earlier but could not apply due to several other things on pipeline. Do you want to got for it?

Abhishek-kumar09 avatar Oct 27 '20 18:10 Abhishek-kumar09

Yeah, glad to do it!

haaarshsingh avatar Oct 27 '20 19:10 haaarshsingh

Great! Thanks for showing your interest :)

Abhishek-kumar09 avatar Oct 27 '20 19:10 Abhishek-kumar09

I really apologise, with school and other side projects I haven't found the time to really work on this. Hope you can understand.

haaarshsingh avatar Jan 16 '21 16:01 haaarshsingh

No worries, I understand. But I am re-opening this issue, so that other could come across and solve it. Thank You for opening it.

Abhishek-kumar09 avatar Jan 16 '21 18:01 Abhishek-kumar09

is this issue is still open ? can i work on it?

sarvesha-jaiswal avatar Mar 21 '21 09:03 sarvesha-jaiswal

Yes, here is the theme written: https://github.com/codeforcauseorg/codeforcause.org/blob/development/src/theme/index.js

You can change all the points were colors were written explicitly to the theme variables

Abhishek-kumar09 avatar Mar 22 '21 18:03 Abhishek-kumar09

yes sure!

sarvesha-jaiswal avatar Mar 25 '21 16:03 sarvesha-jaiswal

Would like to work on this.

Anishpras avatar Mar 27 '21 02:03 Anishpras

@Anishpras sorry, but i have started working on this issue, maybe if i need any help i will contact you

Thanks

sarvesha-jaiswal avatar Mar 27 '21 15:03 sarvesha-jaiswal

Is this issue still open

khushbooag4 avatar Nov 28 '21 04:11 khushbooag4

Oh hi @khushbooag4 Sorry I was missing the notifications for the vacations. I think this issue isn't fixed. Better to able to create a toggle for dark mode. The theme is already defined for dark:

https://github.com/codeforcauseorg/codeforcause.org/blob/0a5308d6772edb47508b4d012314c13e7fe941e5/src/theme/index.js#L69-L98

and applying a dark theme is done in mui in an easy way: https://adityanaik.dev/blog/2020/05/20/material-ui-how-to-easily-set-up-dark-theme-toggle-in-react/

@KeenWarrior @GangaChatrvedi will let you know more about the need of the dark mode in the current UI architecture

Abhishek-kumar09 avatar Dec 12 '21 14:12 Abhishek-kumar09

@khushbooag4 We do not have the figma sheets ready for what we expect in dark mode. So completion of this issue will become ambiguous at this moment.

KeenWarrior avatar Dec 12 '21 17:12 KeenWarrior