cliff-effects icon indicating copy to clipboard operation
cliff-effects copied to clipboard

Clicking 'esc' should trigger 'Cancel' on choices (like modals) while preserving the contents of the modal text boxes if needed

Open knod opened this issue 7 years ago • 2 comments

Replicate:

  1. Click 'Submit Feedback'
  2. Press 'esc'

Result I'd Expect:

  • Modal would close

Actual Result:

  • Nothing happens

Environment:

App version or commit id at the time: e447ea49367050f62f8acd639cb0f3ecb0b14b9d

Other Notes

knod avatar Oct 12 '18 22:10 knod

So we can change this, but I want to note that I did this intentionally for the feedback modal to make it less likely that someone would accidentally lose what they've typed by pressing escape. Maybe if we can get the text boxes to keep their content when the modal is closed and reopened, that would be a better solution, though.

ethanbb avatar Oct 16 '18 02:10 ethanbb

Hmm, that's an interesting point. Dang. I think I remember this conversation. It unfortunately makes the page less accessible. Another option is a regular old prompt that requires an extra confirmation, but that sounds like overkill. I dunno, I'm open to whatever.

knod avatar Oct 16 '18 12:10 knod