angular-dragdrop icon indicating copy to clipboard operation
angular-dragdrop copied to clipboard
verified publisher icon codef0rmer

Drop items are not necessarily deep copied

Open damrem opened this issue 9 years ago • 4 comments

Issue https://github.com/codef0rmer/angular-dragdrop/issues/143 had been closed, but items still were deep copied even when settings were specifying not to do so.

damrem avatar Oct 11 '16 10:10 damrem

@damrem Thanks man..! Can you add a unit test?

codef0rmer avatar Oct 11 '16 15:10 codef0rmer

@codef0rmer Sure! I should find some time soon.

damrem avatar Oct 12 '16 07:10 damrem

Hey, I've finally added tests.

damrem avatar Nov 29 '16 09:11 damrem

@damrem Thanks for adding tests. I noticed that the direction animation breaks by not using deepCopy by default in https://github.com/codef0rmer/angular-dragdrop/blob/master/demo/dnd-insertInline.html.

I do not remember If I intentionally left it to be deep copied for animation to work. Did you face any problem with that?

codef0rmer avatar Dec 04 '16 05:12 codef0rmer