open-catalog icon indicating copy to clipboard operation
open-catalog copied to clipboard

[Fortran] Replace archaic intrinsic functions

Open RRiva opened this issue 1 year ago • 1 comments

Over time, several intrinsic functions have been labeled archaic. See here for the complete list. They should be replaced by their modern equivalent. For example: dsin works for real, while csin and zsin for complex of different kind. They should be replaced by sin, which works for all cases.

RRiva avatar Sep 20 '24 11:09 RRiva

Hi @RRiva,

Thank you once again for your continued contributions to improving the Open Catalog!

We didn’t have a specific check idea on our radar for this suggestion, but it certainly aligns with the Fortran modernization efforts. From what you’ve mentioned, it sounds like using these archaic functions doesn’t necessarily cause compilation failures (e.g., dsin and csin are in the F77 standard), but they could complicate maintenance, especially when refactoring code and changing data types.

As with your previous suggestions, if you're interested, feel free to open a PR proposing an entry for this check in the Open Catalog, following the tips shared in #36. Naturally, if you'd prefer, just let us know and we’ll be happy to take care of it :)

alvrogd avatar Sep 20 '24 13:09 alvrogd