sveltefire icon indicating copy to clipboard operation
sveltefire copied to clipboard

Bump firebase dependency to ^10.0.0

Open mrdavidlaing opened this issue 11 months ago • 7 comments

npm i sveltefire firebase currently fails:

npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR!
npm ERR! While resolving: [email protected]
npm ERR! Found: [email protected]
npm ERR! node_modules/firebase
npm ERR!   firebase@"^10.8.1" from the root project
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer firebase@"^9.0.0" from [email protected]
npm ERR! node_modules/sveltefire
npm ERR!   sveltefire@"*" from the root project
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.

When installed ignoring the dependency conflict - ie: npm i sveltefire firebase --legacy-peer-deps - things appear to work.

Can we upgrade to the latest firebase version?

mrdavidlaing avatar Mar 17 '24 12:03 mrdavidlaing

+1 V10 doesn't appear to introduce any breaking changes that are relevant to this project: https://firebase.google.com/support/release-notes/js#version_1000_-_july_6_2023

IanSaucy avatar Mar 29 '24 15:03 IanSaucy

+1, please merge

RonnyRoos avatar Apr 17 '24 13:04 RonnyRoos

@codediodeio, did you get a chance to look at this? There is at least one issue (https://github.com/codediodeio/sveltefire/issues/126) related to this, and afaik this would fix the problems without anything breaking.

RonnyRoos avatar Apr 23 '24 12:04 RonnyRoos

For anyone else, I posted a way to deal with this issue in a cleaner way than forcing legacy peer deps.

https://github.com/codediodeio/sveltefire/issues/126#issuecomment-2072720481

IanSaucy avatar Apr 23 '24 15:04 IanSaucy

+1

corne-ac avatar Apr 30 '24 13:04 corne-ac

For anyone else, I posted a way to deal with this issue in a cleaner way than forcing legacy peer deps.

#126 (comment)

Thanks for this man, fixed the problem when deploying to Firebase using the Frameworks Experiments.

jiml94 avatar May 04 '24 18:05 jiml94

Pls merge, its a one line change.

shep920 avatar Jul 21 '24 16:07 shep920