geofirex icon indicating copy to clipboard operation
geofirex copied to clipboard

compatibility with firebase > 8.0.0

Open hgrewa opened this issue 4 years ago • 8 comments

Any idea of how to handle the breaking change that comes with firebase 8.0.0 onward

Before 8.0.0 import * as firebase from 'firebase/app'

After 8.0.0 import firebase from 'firebase/app'

Adding geofirex to a new angular application is throwing errors like

Error: node_modules/geofirex/dist/client.d.ts:5:18 - error TS2694: Namespace '"..../node_modules/firebase/index"' has no exported member 'firestore'.

--> geopoint: fb.firestore.GeoPoint;

I tried adding "allowSyntheticDefaultImports": true to tsconfig, but that does not address the issue Is there a workaround?

hgrewa avatar Dec 19 '20 18:12 hgrewa

Need this too.

jasonc624 avatar Jan 03 '21 06:01 jasonc624

Any update on this coming?

dylangolow avatar Jan 14 '21 04:01 dylangolow

Repo seem dead. I tried to modify the source but i got an error when i execute run build:

Created bundle index.cjs.js: 23.75 kB → 6.8 kB (gzip) Created bundle index.esm.js: 23.56 kB → 6.74 kB (gzip) (!) Unresolved dependencies https://rollupjs.org/guide/en/#warning-treating-module-as-external-dependency firebase/firestore (imported by src\client.ts, src\query.ts) created dist/index.cjs.js, dist/index.esm.js in 1.3s

lucdef avatar Mar 22 '21 16:03 lucdef

I created a pull request to support firebase ^8.0.0 feel free to upvote it https://github.com/codediodeio/geofirex/pull/204

tzvc avatar Apr 01 '21 12:04 tzvc

I created a pull request to support firebase ^8.0.0 feel free to upvote it https://github.com/codediodeio/geofirex/pull/204

How can i use your pull request in my project?

It's amazing what you did, i upvoted!

selemessaied avatar Apr 05 '21 12:04 selemessaied

Any update here?

tusharvikky avatar Apr 25 '21 23:04 tusharvikky

Is this project still maintained?

fergardi avatar May 25 '21 14:05 fergardi

It has been several years since the last comment and it appears this repo is no longer maintained, but I came across this discussion while trying to get geofirex to work with a newer version of Firebase.

If it helps anyone else who also comes across this, there appears to be a fork of the package that has been updated to work with newer Firebase versions.

https://www.npmjs.com/package/@thetsf/geofirex

Thank you to the author of the fork!

mattostanik avatar Dec 31 '23 01:12 mattostanik