Retaliation icon indicating copy to clipboard operation
Retaliation copied to clipboard

Fixing problems with current jenkins version

Open tommyziegler opened this issue 10 years ago • 5 comments

  • Fixed certain small issues ** Check for FINISHED or FINALIZED phase ** Use job_url to find lastFailedBuild, because a job name can contain blanks ** Look for the correct username (in case we use authentication '/user/' finds the logged in user and not the commited by user name)

tommyziegler avatar Jul 17 '14 21:07 tommyziegler

I hope you can add this fix to your project.

thx Tommy

tommyziegler avatar Jul 17 '14 21:07 tommyziegler

Hi Tommy. Looks good. Was the driver for the change to make the code compatible with latest version of Jenkins, or the space in the job name?

I'll merge this in, but I wonder if I should also update the README with a version compatibility note?

codedance avatar Jul 18 '14 05:07 codedance

Both cases was the driver in my environment. When you wanna be just compatible with the latest jenkins version, you need of course just the phase checking code. But we use also some jobs with blanks and that's why I fixed both issues.

For more informations about the jerkins version and since when they changed it, I would need to have a deeper look on the jenkins project. Yes a small NOTE is always useful.

tommyziegler avatar Jul 18 '14 12:07 tommyziegler

Hi, I can confirm those changes. I set up the Thunder Missile today and the changes I had to do in the script are exactly the same than this pull request.

paoesco avatar Aug 04 '14 08:08 paoesco

Could you please let me know about the pull into your repo?

tommyziegler avatar Oct 31 '14 00:10 tommyziegler