gazebo icon indicating copy to clipboard operation
gazebo copied to clipboard

build(docker): bump up base alpine version

Open kwonoj opened this issue 8 months ago • 6 comments

Description

This PR attempts to address https://github.com/codecov/feedback/issues/705.

In the current docker there's usage of 3.17 alpine which is EOL, trying to update it to the mainline supported version. Does not introduce any other runtime changes.

Peeking history, there was a recent change in https://github.com/codecov/gazebo/pull/3507 which partially updates the version but the rest of usages are still there. PR aligns the version usage in other places.

Code Example

Notable Changes

Screenshots

Link to Sample Entry

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

kwonoj avatar Apr 24 '25 15:04 kwonoj

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Storybook

Commit Created Cloud Enterprise
e852accfba8df825f7976c237fac8acbad696484 Mon, 12 May 2025 19:08:02 GMT Expired Expired
e852accfba8df825f7976c237fac8acbad696484 Mon, 12 May 2025 19:11:14 GMT Cloud Enterprise

codecov-releaser avatar May 12 '25 19:05 codecov-releaser

@kwonoj when I try to build the image locally, it seems to error out with gpg verification step. A hacky workaround was to add gpg --list-keys right before the gpg --verify calls, but not ideal. I tried 3.21 and that seems to have a different error. Does either build work for you? I'd imagine not because docker, but hey. I'll keep debugging this tomorrow if I have some time.

Thanks for the contribution nonetheless! 🚀

spalmurray avatar May 12 '25 21:05 spalmurray

@spalmurray

I tried 3.21 and that seems to have a different error. Does either build work for you?

Yes, as long as it's non EOL and mainline supported I think it'll work. Thanks!

kwonoj avatar May 12 '25 21:05 kwonoj

Oh sorry @kwonoj what I meant is are you able to build either version on your machine?

spalmurray avatar May 13 '25 15:05 spalmurray

@spalmurray Oh sorry, totally misunderstood q.

When I run make build.local, hitting

=> ERROR [uploader 7/9] RUN curl -s -o linux/codecov https://uploader.codecov.io/latest/linux/codeco...

regardless on 3.17(main branch) or my pr so can't say for sure if it's base image issue or not.

kwonoj avatar May 13 '25 16:05 kwonoj

@spalmurray Somehow I keep stuck at running uploader step on local machine, tried to confirm with CI https://github.com/kwonoj/gazebo/actions/runs/15049534511/job/42300579038?pr=2 which seems ok. Don't know why local docker have those issues.

kwonoj avatar May 15 '25 15:05 kwonoj

@spalmurray may I be able to quick check if there's anything I can do to verify & push this forward?

kwonoj avatar May 22 '25 18:05 kwonoj

hey @kwonoj! Got busy and didn't see your messages, so sorry about that! I'll take a look at this on Monday. Have a nice weekend 😄

spalmurray avatar May 23 '25 22:05 spalmurray

Thanks!

kwonoj avatar May 23 '25 22:05 kwonoj

https://github.com/codecov/gazebo/pull/3875 is the best I could come up with to get it to build. The gpg thing is weird, but I'm fine with this 😅

spalmurray avatar May 26 '25 20:05 spalmurray

Thanks, could see it as well. Weird but 🤞 it works. Appreciaate for the help!

kwonoj avatar May 27 '25 18:05 kwonoj