gazebo icon indicating copy to clipboard operation
gazebo copied to clipboard

feat: Glue in pass/fail/skip params into tooltip via test results query

Open ajay-sentry opened this issue 1 year ago • 1 comments

Description

This PR glues in the pass fail and skip counts from the test results query to the tooltip shown when you hover the flake rate field. A minor refactor had to be done when generating the test results "values" to show on the table because multiple values from the query are being populated onto a single column.

I basically just moved over that component logic to the column and had the column render the value itself instead of having it on the column.

Screenshots

Screenshot 2024-10-10 at 4 52 37 PM

Link to Sample Entry

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

ajay-sentry avatar Oct 10 '24 23:10 ajay-sentry

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Storybook

Commit Created Cloud Enterprise
aa81658bb5b179e6c9a47d4b441faa0627526af4 Fri, 11 Oct 2024 00:02:42 GMT Expired Expired
1d9083c4cb3c6004a5911190496e11e744c75802 Fri, 11 Oct 2024 16:40:46 GMT Cloud Enterprise

codecov-releaser avatar Oct 11 '24 00:10 codecov-releaser

Bundle Report

Changes will increase total bundle size by 3.35kB (0.05%) :arrow_up:. This is within the configured threshold :white_check_mark:

Detailed changes
Bundle name Size Change
gazebo-staging-array-push 6.15MB 3.35kB (0.05%) :arrow_up:

codecov-staging[bot] avatar Oct 11 '24 16:10 codecov-staging[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 98.98%. Comparing base (4a58220) to head (1d9083c). Report is 1 commits behind head on tests-analytics-v2.

:white_check_mark: All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@                   Coverage Diff                   @@
##           tests-analytics-v2    #3384       +/-   ##
=======================================================
+ Coverage               51.85%   98.98%   +47.12%     
=======================================================
  Files                     807      807               
  Lines                   14257    14257               
  Branches                 3929     3929               
=======================================================
+ Hits                     7393    14112     +6719     
+ Misses                   6041      134     -5907     
+ Partials                  823       11      -812     
Files with missing lines Coverage Δ
...ledTestsPage/FailedTestsTable/FailedTestsTable.tsx 98.70% <100.00%> (+98.70%) :arrow_up:
...ailedTestsPage/SelectorSection/SelectorSection.tsx 0.00% <ø> (ø)
.../useInfiniteTestResults/useInfiniteTestResults.tsx 100.00% <ø> (+100.00%) :arrow_up:

... and 385 files with indirect coverage changes

Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 100.00% <ø> (ø)
Pages 98.62% <100.00%> (+84.10%) :arrow_up:
Services 99.45% <ø> (+1.23%) :arrow_up:
Shared 99.80% <ø> (+1.89%) :arrow_up:
UI 99.10% <ø> (+0.55%) :arrow_up:

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4a58220...1d9083c. Read the comment docs.

codecov[bot] avatar Oct 11 '24 16:10 codecov[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 98.98%. Comparing base (4a58220) to head (1d9083c). Report is 1 commits behind head on tests-analytics-v2.

:white_check_mark: All tests successful. No failed tests found.

Impacted file tree graph

@@                   Coverage Diff                   @@
##           tests-analytics-v2    #3384       +/-   ##
=======================================================
+ Coverage               41.75%   98.98%   +57.22%     
=======================================================
  Files                     807      807               
  Lines                   14257    14257               
  Branches                 3924     3929        +5     
=======================================================
+ Hits                     5953    14112     +8159     
+ Misses                   7278      134     -7144     
+ Partials                 1026       11     -1015     
Files with missing lines Coverage Δ
...ledTestsPage/FailedTestsTable/FailedTestsTable.tsx 98.70% <100.00%> (+98.70%) :arrow_up:
...ailedTestsPage/SelectorSection/SelectorSection.tsx 0.00% <ø> (ø)
.../useInfiniteTestResults/useInfiniteTestResults.tsx 100.00% <ø> (+100.00%) :arrow_up:

... and 457 files with indirect coverage changes

Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 100.00% <ø> (ø)
Pages 98.62% <100.00%> (+87.39%) :arrow_up:
Services 99.45% <ø> (+41.71%) :arrow_up:
Shared 99.80% <ø> (+1.89%) :arrow_up:
UI 99.10% <ø> (+0.55%) :arrow_up:

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4a58220...1d9083c. Read the comment docs.

codecov-qa[bot] avatar Oct 11 '24 16:10 codecov-qa[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 98.98%. Comparing base (4a58220) to head (1d9083c).

:white_check_mark: All tests successful. No failed tests found.

Impacted file tree graph

@@                   Coverage Diff                   @@
##           tests-analytics-v2    #3384       +/-   ##
=======================================================
+ Coverage               41.75%   98.98%   +57.22%     
=======================================================
  Files                     807      807               
  Lines                   14257    14257               
  Branches                 3924     3929        +5     
=======================================================
+ Hits                     5953    14112     +8159     
+ Misses                   7278      134     -7144     
+ Partials                 1026       11     -1015     
Files Coverage Δ
...ledTestsPage/FailedTestsTable/FailedTestsTable.tsx 98.70% <100.00%> (+98.70%) :arrow_up:
...ailedTestsPage/SelectorSection/SelectorSection.tsx 0.00% <ø> (ø)
.../useInfiniteTestResults/useInfiniteTestResults.tsx 100.00% <ø> (+100.00%) :arrow_up:

... and 457 files with indirect coverage changes

Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 100.00% <ø> (ø)
Pages 98.62% <100.00%> (+87.39%) :arrow_up:
Services 99.45% <ø> (+41.71%) :arrow_up:
Shared 99.80% <ø> (+1.89%) :arrow_up:
UI 99.10% <ø> (+0.55%) :arrow_up:

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4a58220...1d9083c. Read the comment docs.

codecov-public-qa[bot] avatar Oct 11 '24 16:10 codecov-public-qa[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

:white_check_mark: All tests successful. No failed tests found.

Impacted file tree graph

@@                   Coverage Diff                   @@
##           tests-analytics-v2    #3384       +/-   ##
=======================================================
+ Coverage               41.75%   98.98%   +57.22%     
=======================================================
  Files                     807      807               
  Lines                   14257    14257               
  Branches                 3924     3924               
=======================================================
+ Hits                     5953    14112     +8159     
+ Misses                   7278      134     -7144     
+ Partials                 1026       11     -1015     
Files with missing lines Coverage Δ
...ledTestsPage/FailedTestsTable/FailedTestsTable.tsx 98.70% <100.00%> (+98.70%) :arrow_up:
...ailedTestsPage/SelectorSection/SelectorSection.tsx 0.00% <ø> (ø)
.../useInfiniteTestResults/useInfiniteTestResults.tsx 100.00% <ø> (+100.00%) :arrow_up:

... and 457 files with indirect coverage changes

Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 100.00% <ø> (ø)
Pages 98.62% <100.00%> (+87.39%) :arrow_up:
Services 99.45% <ø> (+41.71%) :arrow_up:
Shared 99.80% <ø> (+1.89%) :arrow_up:
UI 99.10% <ø> (+0.55%) :arrow_up:

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4a58220...1d9083c. Read the comment docs.

Bundle Report

Changes will increase total bundle size by 411 bytes (0.01%) :arrow_up:. This is within the configured threshold :white_check_mark:

Detailed changes
Bundle name Size Change
gazebo-production-array-push 6.15MB 411 bytes (0.01%) :arrow_up:

codecov[bot] avatar Oct 11 '24 16:10 codecov[bot]