gazebo icon indicating copy to clipboard operation
gazebo copied to clipboard

feat: Update commit graphql queries to use new coverage and bundleAna…

Open calvin-codecov opened this issue 1 year ago • 7 comments

…lysis schemas

Description

Closes https://github.com/codecov/engineering-team/issues/2285 Related to changes made in api at https://github.com/codecov/codecov-api/pull/847 - TLDR: following fields in the Commit.graphql type were pulled out into another subtype.

components, flagNames, coverageFile and totals were moved down one level into coverageAnalytics bundleAnalysisCompareWithParent and bundleAnalysisReport were moved down one level into bundleAnalysis.

The only changes made in this PR are adding in an extra level of nesting for these 6 fields in the Commit type.

Made changes to

  • type Repository's commit
  • type Branch's head
  • type Commit's parent
  • and type Pull's head , as they are all of type Commit, and their uses across the codebase.

*Type Pull's comparedTo did not use any of those fields so did not need any changes even though it is also of type Commit.

Code Example

Notable Changes

Screenshots

Link to Sample Entry

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

calvin-codecov avatar Oct 07 '24 19:10 calvin-codecov

Codecov Report

Attention: Patch coverage is 95.45455% with 1 line in your changes missing coverage. Please review.

:white_check_mark: All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/services/bundleAnalysis/useBundleAssets.tsx 66.66% 1 Missing :warning:

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3363   +/-   ##
=======================================
  Coverage   99.18%   99.18%           
=======================================
  Files         805      805           
  Lines       14232    14233    +1     
  Branches     3927     3927           
=======================================
+ Hits        14116    14117    +1     
  Misses        107      107           
  Partials        9        9           
Files with missing lines Coverage Δ
...mmitBundleAnalysis/BundleMessage/BundleMessage.tsx 100.00% <100.00%> (ø)
...Page/CommitBundleAnalysis/CommitBundleAnalysis.tsx 100.00% <100.00%> (ø)
...tBundleAnalysisTable/CommitBundleAnalysisTable.tsx 100.00% <100.00%> (ø)
...CommitCoverageSummary/hooks/useCommitForSummary.js 100.00% <100.00%> (ø)
...pages/CommitDetailPage/hooks/useCommitPageData.tsx 100.00% <ø> (ø)
...uestPage/PullBundleAnalysis/PullBundleAnalysis.tsx 100.00% <100.00%> (ø)
...alysis/PullBundleHeadTable/PullBundleHeadTable.tsx 100.00% <100.00%> (ø)
...Summary/CompareSummary/usePullForCompareSummary.js 100.00% <ø> (ø)
...CommitsTab/CommitsTable/createCommitsTableData.tsx 93.93% <100.00%> (ø)
...rc/pages/PullRequestPage/hooks/usePullPageData.tsx 100.00% <ø> (ø)
... and 24 more
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 100.00% <ø> (ø)
Pages 98.94% <100.00%> (+<0.01%) :arrow_up:
Services 99.45% <83.33%> (ø)
Shared 99.80% <ø> (ø)
UI 99.10% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b3910ea...c206e3d. Read the comment docs.

codecov-staging[bot] avatar Oct 07 '24 19:10 codecov-staging[bot]

Codecov Report

Attention: Patch coverage is 95.45455% with 1 line in your changes missing coverage. Please review.

Project coverage is 99.18%. Comparing base (b3910ea) to head (c206e3d).

:white_check_mark: All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3363   +/-   ##
=======================================
  Coverage   99.18%   99.18%           
=======================================
  Files         805      805           
  Lines       14232    14233    +1     
  Branches     3922     3927    +5     
=======================================
+ Hits        14116    14117    +1     
  Misses        107      107           
  Partials        9        9           
Files Coverage Δ
...mmitBundleAnalysis/BundleMessage/BundleMessage.tsx 100.00% <100.00%> (ø)
...Page/CommitBundleAnalysis/CommitBundleAnalysis.tsx 100.00% <100.00%> (ø)
...tBundleAnalysisTable/CommitBundleAnalysisTable.tsx 100.00% <100.00%> (ø)
...CommitCoverageSummary/hooks/useCommitForSummary.js 100.00% <100.00%> (ø)
...pages/CommitDetailPage/hooks/useCommitPageData.tsx 100.00% <ø> (ø)
...uestPage/PullBundleAnalysis/PullBundleAnalysis.tsx 100.00% <100.00%> (ø)
...alysis/PullBundleHeadTable/PullBundleHeadTable.tsx 100.00% <100.00%> (ø)
...Summary/CompareSummary/usePullForCompareSummary.js 100.00% <ø> (ø)
...CommitsTab/CommitsTable/createCommitsTableData.tsx 93.93% <100.00%> (ø)
...rc/pages/PullRequestPage/hooks/usePullPageData.tsx 100.00% <ø> (ø)
... and 24 more
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 100.00% <ø> (ø)
Pages 98.94% <100.00%> (+<0.01%) :arrow_up:
Services 99.45% <83.33%> (ø)
Shared 99.80% <ø> (ø)
UI 99.10% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b3910ea...c206e3d. Read the comment docs.

codecov-public-qa[bot] avatar Oct 07 '24 19:10 codecov-public-qa[bot]

Codecov Report

Attention: Patch coverage is 95.45455% with 1 line in your changes missing coverage. Please review.

Project coverage is 99.18%. Comparing base (b3910ea) to head (c206e3d). Report is 1 commits behind head on main.

:white_check_mark: All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/services/bundleAnalysis/useBundleAssets.tsx 66.66% 1 Missing :warning:

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3363   +/-   ##
=======================================
  Coverage   99.18%   99.18%           
=======================================
  Files         805      805           
  Lines       14232    14233    +1     
  Branches     3922     3922           
=======================================
+ Hits        14116    14117    +1     
  Misses        107      107           
  Partials        9        9           
Files with missing lines Coverage Δ
...mmitBundleAnalysis/BundleMessage/BundleMessage.tsx 100.00% <100.00%> (ø)
...Page/CommitBundleAnalysis/CommitBundleAnalysis.tsx 100.00% <100.00%> (ø)
...tBundleAnalysisTable/CommitBundleAnalysisTable.tsx 100.00% <100.00%> (ø)
...CommitCoverageSummary/hooks/useCommitForSummary.js 100.00% <100.00%> (ø)
...pages/CommitDetailPage/hooks/useCommitPageData.tsx 100.00% <ø> (ø)
...uestPage/PullBundleAnalysis/PullBundleAnalysis.tsx 100.00% <100.00%> (ø)
...alysis/PullBundleHeadTable/PullBundleHeadTable.tsx 100.00% <100.00%> (ø)
...Summary/CompareSummary/usePullForCompareSummary.js 100.00% <ø> (ø)
...CommitsTab/CommitsTable/createCommitsTableData.tsx 93.93% <100.00%> (ø)
...rc/pages/PullRequestPage/hooks/usePullPageData.tsx 100.00% <ø> (ø)
... and 24 more
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 100.00% <ø> (ø)
Pages 98.94% <100.00%> (+<0.01%) :arrow_up:
Services 99.45% <83.33%> (ø)
Shared 99.80% <ø> (ø)
UI 99.10% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b3910ea...c206e3d. Read the comment docs.

codecov-qa[bot] avatar Oct 07 '24 19:10 codecov-qa[bot]

Bundle Report

Changes will increase total bundle size by 4.8kB (0.08%) :arrow_up:. This is within the configured threshold :white_check_mark:

Detailed changes
Bundle name Size Change
gazebo-staging-array-push 6.15MB 4.8kB (0.08%) :arrow_up:

codecov-staging[bot] avatar Oct 07 '24 19:10 codecov-staging[bot]

Bundle Report

Changes will increase total bundle size by 4.8kB (0.08%) :arrow_up:. This is within the configured threshold :white_check_mark:

Detailed changes
Bundle name Size Change
gazebo-production-array-push 6.15MB 4.8kB (0.08%) :arrow_up:

codecov[bot] avatar Oct 07 '24 19:10 codecov[bot]

Codecov Report

Attention: Patch coverage is 95.45455% with 1 line in your changes missing coverage. Please review.

Project coverage is 99.18%. Comparing base (b3910ea) to head (c206e3d). Report is 1 commits behind head on main.

:white_check_mark: All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/services/bundleAnalysis/useBundleAssets.tsx 66.66% 1 Missing :warning:
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3363   +/-   ##
=======================================
  Coverage   99.18%   99.18%           
=======================================
  Files         805      805           
  Lines       14232    14233    +1     
  Branches     3922     3922           
=======================================
+ Hits        14116    14117    +1     
  Misses        107      107           
  Partials        9        9           
Files with missing lines Coverage Δ
...mmitBundleAnalysis/BundleMessage/BundleMessage.tsx 100.00% <100.00%> (ø)
...Page/CommitBundleAnalysis/CommitBundleAnalysis.tsx 100.00% <100.00%> (ø)
...tBundleAnalysisTable/CommitBundleAnalysisTable.tsx 100.00% <100.00%> (ø)
...CommitCoverageSummary/hooks/useCommitForSummary.js 100.00% <100.00%> (ø)
...pages/CommitDetailPage/hooks/useCommitPageData.tsx 100.00% <ø> (ø)
...uestPage/PullBundleAnalysis/PullBundleAnalysis.tsx 100.00% <100.00%> (ø)
...alysis/PullBundleHeadTable/PullBundleHeadTable.tsx 100.00% <100.00%> (ø)
...Summary/CompareSummary/usePullForCompareSummary.js 100.00% <ø> (ø)
...CommitsTab/CommitsTable/createCommitsTableData.tsx 93.93% <100.00%> (ø)
...rc/pages/PullRequestPage/hooks/usePullPageData.tsx 100.00% <ø> (ø)
... and 24 more
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 100.00% <ø> (ø)
Pages 98.94% <100.00%> (+<0.01%) :arrow_up:
Services 99.45% <83.33%> (ø)
Shared 99.80% <ø> (ø)
UI 99.10% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b3910ea...c206e3d. Read the comment docs.

codecov[bot] avatar Oct 07 '24 19:10 codecov[bot]

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Storybook

Commit Created Cloud Enterprise
543d7cee9b75be3e565801eedf483f65de168be5 Mon, 07 Oct 2024 19:28:57 GMT Expired Expired
543d7cee9b75be3e565801eedf483f65de168be5 Mon, 07 Oct 2024 19:33:13 GMT Expired Expired
f4386a028c6b54620997f7fb8182c86e6d0d16f3 Tue, 08 Oct 2024 16:43:47 GMT Expired Expired
56ff161d14c39e31985162fbd19f52454dc29d07 Tue, 08 Oct 2024 21:01:08 GMT Expired Expired
5aa73e58bb594faf9b2c63662873498ec1444de6 Wed, 09 Oct 2024 09:21:44 GMT Expired Expired
c2f266c64e1b4bab95217e98fd186496a7b65177 Wed, 09 Oct 2024 16:39:01 GMT Expired Expired
159269430a5b788b65d8ba2d1ac4c2e9e80b2f74 Thu, 10 Oct 2024 16:38:23 GMT Expired Expired
c206e3d56fe97c1d922df54ac601c6e279be3788 Tue, 15 Oct 2024 20:46:50 GMT Cloud Enterprise

codecov-releaser avatar Oct 07 '24 19:10 codecov-releaser