gazebo icon indicating copy to clipboard operation
gazebo copied to clipboard

chore: Update pulls page files changed diff to new renderer

Open nicholas-codecov opened this issue 1 year ago • 6 comments
trafficstars

Description

Ticket: codecov/engineering-team#2590

Notable Changes

  • Update FileDiff to conditionally use new virtual diff renderer
  • Update tests

Screenshots

Screenshot 2024-10-07 at 14 16 25

nicholas-codecov avatar Oct 07 '24 17:10 nicholas-codecov

Codecov Report

Attention: Patch coverage is 92.30769% with 1 line in your changes missing coverage. Please review.

Project coverage is 99.17%. Comparing base (978512d) to head (262e801). Report is 1 commits behind head on main.

:white_check_mark: All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...FilesChangedTab/FilesChanged/FileDiff/FileDiff.jsx 92.30% 1 Missing :warning:

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3359      +/-   ##
==========================================
- Coverage   99.18%   99.17%   -0.01%     
==========================================
  Files         805      805              
  Lines       14244    14255      +11     
  Branches     3926     3935       +9     
==========================================
+ Hits        14128    14138      +10     
- Misses        107      108       +1     
  Partials        9        9              
Files with missing lines Coverage Δ
...FilesChangedTab/FilesChanged/FileDiff/FileDiff.jsx 97.22% <92.30%> (-2.78%) :arrow_down:
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 100.00% <ø> (ø)
Pages 98.93% <92.30%> (-0.02%) :arrow_down:
Services 99.45% <ø> (ø)
Shared 99.80% <ø> (ø)
UI 99.10% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 978512d...262e801. Read the comment docs.

codecov-qa[bot] avatar Oct 07 '24 17:10 codecov-qa[bot]

Codecov Report

Attention: Patch coverage is 92.30769% with 1 line in your changes missing coverage. Please review.

:white_check_mark: All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...FilesChangedTab/FilesChanged/FileDiff/FileDiff.jsx 92.30% 1 Missing :warning:

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3359      +/-   ##
==========================================
- Coverage   99.18%   99.17%   -0.01%     
==========================================
  Files         805      805              
  Lines       14244    14255      +11     
  Branches     3926     3935       +9     
==========================================
+ Hits        14128    14138      +10     
- Misses        107      108       +1     
  Partials        9        9              
Files with missing lines Coverage Δ
...FilesChangedTab/FilesChanged/FileDiff/FileDiff.jsx 97.22% <92.30%> (-2.78%) :arrow_down:
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 100.00% <ø> (ø)
Pages 98.93% <92.30%> (-0.02%) :arrow_down:
Services 99.45% <ø> (ø)
Shared 99.80% <ø> (ø)
UI 99.10% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 978512d...262e801. Read the comment docs.

Codecov Report

Attention: Patch coverage is 92.30769% with 1 line in your changes missing coverage. Please review.

Project coverage is 99.17%. Comparing base (978512d) to head (262e801).

:white_check_mark: All tests successful. No failed tests found.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3359      +/-   ##
==========================================
- Coverage   99.18%   99.17%   -0.01%     
==========================================
  Files         805      805              
  Lines       14244    14255      +11     
  Branches     3931     3930       -1     
==========================================
+ Hits        14128    14138      +10     
- Misses        107      108       +1     
  Partials        9        9              
Files Coverage Δ
...FilesChangedTab/FilesChanged/FileDiff/FileDiff.jsx 97.22% <92.30%> (-2.78%) :arrow_down:
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 100.00% <ø> (ø)
Pages 98.93% <92.30%> (-0.02%) :arrow_down:
Services 99.45% <ø> (ø)
Shared 99.80% <ø> (ø)
UI 99.10% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 978512d...262e801. Read the comment docs.

codecov-public-qa[bot] avatar Oct 07 '24 17:10 codecov-public-qa[bot]

Codecov Report

Attention: Patch coverage is 92.30769% with 1 line in your changes missing coverage. Please review.

Project coverage is 99.17%. Comparing base (978512d) to head (262e801). Report is 1 commits behind head on main.

:white_check_mark: All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...FilesChangedTab/FilesChanged/FileDiff/FileDiff.jsx 92.30% 1 Missing :warning:
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3359      +/-   ##
==========================================
- Coverage   99.18%   99.17%   -0.01%     
==========================================
  Files         805      805              
  Lines       14244    14255      +11     
  Branches     3926     3935       +9     
==========================================
+ Hits        14128    14138      +10     
- Misses        107      108       +1     
  Partials        9        9              
Files with missing lines Coverage Δ
...FilesChangedTab/FilesChanged/FileDiff/FileDiff.jsx 97.22% <92.30%> (-2.78%) :arrow_down:
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 100.00% <ø> (ø)
Pages 98.93% <92.30%> (-0.02%) :arrow_down:
Services 99.45% <ø> (ø)
Shared 99.80% <ø> (ø)
UI 99.10% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 978512d...262e801. Read the comment docs.

codecov[bot] avatar Oct 07 '24 17:10 codecov[bot]

Bundle Report

Changes will decrease total bundle size by 4.95kB (-0.08%) :arrow_down:. This is within the configured threshold :white_check_mark:

Detailed changes
Bundle name Size Change
gazebo-production-array-push 6.14MB 4.95kB (-0.08%) :arrow_down:

codecov[bot] avatar Oct 07 '24 17:10 codecov[bot]

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Storybook

Commit Created Cloud Enterprise
45735669421b88c983add5eda590aad563682adc Mon, 07 Oct 2024 17:30:36 GMT Expired Expired
3d65adca3addb0799f373a5db6335358aec6c2ba Tue, 08 Oct 2024 10:57:38 GMT Expired Expired
530f3d948eff152a592f3e6887722f964372e343 Wed, 16 Oct 2024 16:04:09 GMT Expired Expired
262e8016c876f797527d7e3a1ef1dc4e3f7881ca Wed, 16 Oct 2024 16:24:41 GMT Cloud Enterprise

codecov-releaser avatar Oct 07 '24 17:10 codecov-releaser