gazebo icon indicating copy to clipboard operation
gazebo copied to clipboard

chore: Add new diff viewer to commit files changed

Open nicholas-codecov opened this issue 1 year ago • 7 comments

Description

This PR updates the commit detail page files changed commit diff viewer to conditionally use the new virtual diff renderer.

Ticket: codecov/engineering-team#2590

Notable Changes

  • Add nullable to impactedFile in useComparisonForCommitAndParent as it was missing
  • Setup CommitFileDiff to conditionally render old viewer vs new viewer based off of a feature flag
  • Update tests

Screenshots

Screenshot 2024-10-07 at 07 47 24

nicholas-codecov avatar Oct 07 '24 10:10 nicholas-codecov

Bundle Report

Changes will increase total bundle size by 61.97kB (1.02%) :arrow_up:. This is within the configured threshold :white_check_mark:

Detailed changes
Bundle name Size Change
gazebo-staging-array-push 6.14MB 61.97kB (1.02%) :arrow_up:

codecov-staging[bot] avatar Oct 07 '24 10:10 codecov-staging[bot]

Bundle Report

Changes will decrease total bundle size by 4.95kB (-0.08%) :arrow_down:. This is within the configured threshold :white_check_mark:

Detailed changes
Bundle name Size Change
gazebo-production-array-push 6.14MB 4.95kB (-0.08%) :arrow_down:

codecov[bot] avatar Oct 07 '24 10:10 codecov[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.18%. Comparing base (caf3646) to head (ce46fd1). Report is 1 commits behind head on main.

:white_check_mark: All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3356   +/-   ##
=======================================
  Coverage   99.18%   99.18%           
=======================================
  Files         805      805           
  Lines       14233    14244   +11     
  Branches     3927     3926    -1     
=======================================
+ Hits        14117    14128   +11     
  Misses        107      107           
  Partials        9        9           
Files with missing lines Coverage Δ
...hangedTab/shared/CommitFileDiff/CommitFileDiff.jsx 100.00% <100.00%> (ø)
...ommitAndParent/useComparisonForCommitAndParent.tsx 100.00% <ø> (ø)
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 100.00% <ø> (ø)
Pages 98.94% <100.00%> (+<0.01%) :arrow_up:
Services 99.45% <ø> (ø)
Shared 99.80% <ø> (ø)
UI 99.10% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update caf3646...ce46fd1. Read the comment docs.

codecov[bot] avatar Oct 07 '24 10:10 codecov[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.18%. Comparing base (caf3646) to head (ce46fd1).

:white_check_mark: All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3356   +/-   ##
=======================================
  Coverage   99.18%   99.18%           
=======================================
  Files         805      805           
  Lines       14233    14244   +11     
  Branches     3922     3926    +4     
=======================================
+ Hits        14117    14128   +11     
  Misses        107      107           
  Partials        9        9           
Files Coverage Δ
...hangedTab/shared/CommitFileDiff/CommitFileDiff.jsx 100.00% <100.00%> (ø)
...ommitAndParent/useComparisonForCommitAndParent.tsx 100.00% <ø> (ø)
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 100.00% <ø> (ø)
Pages 98.94% <100.00%> (+<0.01%) :arrow_up:
Services 99.45% <ø> (ø)
Shared 99.80% <ø> (ø)
UI 99.10% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update caf3646...ce46fd1. Read the comment docs.

codecov-public-qa[bot] avatar Oct 07 '24 10:10 codecov-public-qa[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

:white_check_mark: All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3356   +/-   ##
=======================================
  Coverage   99.18%   99.18%           
=======================================
  Files         805      805           
  Lines       14233    14244   +11     
  Branches     3927     3926    -1     
=======================================
+ Hits        14117    14128   +11     
  Misses        107      107           
  Partials        9        9           
Files with missing lines Coverage Δ
...hangedTab/shared/CommitFileDiff/CommitFileDiff.jsx 100.00% <100.00%> (ø)
...ommitAndParent/useComparisonForCommitAndParent.tsx 100.00% <ø> (ø)
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 100.00% <ø> (ø)
Pages 98.94% <100.00%> (+<0.01%) :arrow_up:
Services 99.45% <ø> (ø)
Shared 99.80% <ø> (ø)
UI 99.10% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update caf3646...ce46fd1. Read the comment docs.

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Storybook

Commit Created Cloud Enterprise
47aa83a9ef5ae16365a11ebf73faea4fb8d69e8f Mon, 07 Oct 2024 10:54:32 GMT Expired Expired
041b10282d289bf52ef9d962245172ffa9acf781 Mon, 07 Oct 2024 16:57:28 GMT Expired Expired
ce46fd183b328fb2bb03687edbcde3b532454cbb Wed, 16 Oct 2024 15:57:25 GMT Expired Expired
ce46fd183b328fb2bb03687edbcde3b532454cbb Wed, 16 Oct 2024 16:01:03 GMT Cloud Enterprise

codecov-releaser avatar Oct 07 '24 10:10 codecov-releaser

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.18%. Comparing base (caf3646) to head (ce46fd1). Report is 1 commits behind head on main.

:white_check_mark: All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3356   +/-   ##
=======================================
  Coverage   99.18%   99.18%           
=======================================
  Files         805      805           
  Lines       14233    14244   +11     
  Branches     3922     3931    +9     
=======================================
+ Hits        14117    14128   +11     
  Misses        107      107           
  Partials        9        9           
Files with missing lines Coverage Δ
...hangedTab/shared/CommitFileDiff/CommitFileDiff.jsx 100.00% <100.00%> (ø)
...ommitAndParent/useComparisonForCommitAndParent.tsx 100.00% <ø> (ø)
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 100.00% <ø> (ø)
Pages 98.94% <100.00%> (+<0.01%) :arrow_up:
Services 99.45% <ø> (ø)
Shared 99.80% <ø> (ø)
UI 99.10% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update caf3646...ce46fd1. Read the comment docs.

codecov-qa[bot] avatar Oct 07 '24 10:10 codecov-qa[bot]