gazebo icon indicating copy to clipboard operation
gazebo copied to clipboard

fix: Truncate sunburst chart's breadcrumbs

Open suejung-sentry opened this issue 1 year ago • 7 comments

Description

Code Example

Notable Changes

Screenshots

Link to Sample Entry

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

suejung-sentry avatar Oct 05 '24 02:10 suejung-sentry

Bundle Report

Changes will increase total bundle size by 225 bytes (0.0%) :arrow_up:. This is within the configured threshold :white_check_mark:

Detailed changes
Bundle name Size Change
gazebo-production-array-push 6.13MB 225 bytes (0.0%) :arrow_up:

codecov[bot] avatar Oct 05 '24 02:10 codecov[bot]

Codecov Report

Attention: Patch coverage is 87.50000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 99.16%. Comparing base (fff945c) to head (711739a).

:white_check_mark: All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...rageTab/OverviewTab/subroute/Sunburst/Sunburst.jsx 87.50% 2 Missing :warning:
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3355      +/-   ##
==========================================
- Coverage   99.17%   99.16%   -0.02%     
==========================================
  Files         803      803              
  Lines       14153    14169      +16     
  Branches     3904     3906       +2     
==========================================
+ Hits        14036    14050      +14     
- Misses        108      110       +2     
  Partials        9        9              
Files with missing lines Coverage Δ
...rageTab/OverviewTab/subroute/Sunburst/Sunburst.jsx 87.09% <87.50%> (+0.43%) :arrow_up:
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 100.00% <ø> (ø)
Pages 98.93% <87.50%> (-0.03%) :arrow_down:
Services 99.45% <ø> (ø)
Shared 99.80% <ø> (ø)
UI 99.10% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update fff945c...711739a. Read the comment docs.

codecov[bot] avatar Oct 05 '24 02:10 codecov[bot]

:x: 1 Tests Failed:

Tests completed Failed Passed Skipped
1180 1 1179 0
View the top 1 failed tests by shortest run time
src/ui/Breadcrumb/Breadcrumb.test.tsx > Breadcrumb &gt; Renders breadcrumb &gt; renders a link with the right URL
Stack Traces | 0.0537s run time
TypeError: Cannot read properties of undefined (reading &apos;length&apos;)
 ❯ map .../ui/Breadcrumb/Breadcrumb.tsx:45:50
 ❯ calculateVisibleItems .../ui/Breadcrumb/Breadcrumb.tsx:43:7
 ❯ .../ui/Breadcrumb/Breadcrumb.tsx:68:12
 ❯ commitHookEffectListMount .../react-dom/cjs/react-dom.development.js:23189:26
 ❯ commitPassiveMountOnFiber .../react-dom/cjs/react-dom.development.js:24970:11
 ❯ commitPassiveMountEffects_complete .../react-dom/cjs/react-dom.development.js:24930:9
 ❯ commitPassiveMountEffects_begin .../react-dom/cjs/react-dom.development.js:24917:7
 ❯ commitPassiveMountEffects .../react-dom/cjs/react-dom.development.js:24905:3
 ❯ flushPassiveEffectsImpl .../react-dom/cjs/react-dom.development.js:27078:3

To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard

codecov-qa[bot] avatar Oct 05 '24 02:10 codecov-qa[bot]

:x: 2 Tests Failed:

Tests completed Failed Passed Skipped
1484 2 1482 0
View the top 2 failed tests by shortest run time
src/ui/Breadcrumb/Breadcrumb.test.tsx Breadcrumb &gt; Renders breadcrumb &gt; renders a link with the right URL
Stack Traces | 0.0537s run time
TypeError: Cannot read properties of undefined (reading &apos;length&apos;)
 ❯ map .../ui/Breadcrumb/Breadcrumb.tsx:45:50
 ❯ calculateVisibleItems .../ui/Breadcrumb/Breadcrumb.tsx:43:7
 ❯ .../ui/Breadcrumb/Breadcrumb.tsx:68:12
 ❯ commitHookEffectListMount .../react-dom/cjs/react-dom.development.js:23189:26
 ❯ commitPassiveMountOnFiber .../react-dom/cjs/react-dom.development.js:24970:11
 ❯ commitPassiveMountEffects_complete .../react-dom/cjs/react-dom.development.js:24930:9
 ❯ commitPassiveMountEffects_begin .../react-dom/cjs/react-dom.development.js:24917:7
 ❯ commitPassiveMountEffects .../react-dom/cjs/react-dom.development.js:24905:3
 ❯ flushPassiveEffectsImpl .../react-dom/cjs/react-dom.development.js:27078:3
src/shared/ContentsTable/FileBreadcrumb/FileBreadcrumb.test.jsx FileBreadcrumb &gt; path is provided in route &gt; renders the breadcrumb
Stack Traces | 0.078s run time
TestingLibraryElementError: Unable to find an accessible element with the role &quot;link&quot; and name &quot;coolrepo&quot;

Here are the accessible roles:

  navigation:

  Name &quot;&quot;:
  &lt;nav
    class=&quot;flex flex-1 items-center truncate text-ds-gray-octonary [&amp;&gt;*]:mx-1&quot;
  /&gt;

  --------------------------------------------------

Ignored nodes: comments, script, style
&lt;body&gt;
  &lt;div&gt;
    &lt;nav
      class=&quot;flex flex-1 items-center truncate text-ds-gray-octonary [&amp;&gt;*]:mx-1&quot;
    &gt;
      &lt;a
        class=&quot;
  font-sans cursor-pointer

  hover:underline

  focus:ring-2
 text-ds-blue-default inline-flex items-center gap-1 truncate&quot;
        title=&quot;coolrepo&quot;
      &gt;
        coolrepo
      &lt;/a&gt;
      &lt;span
        class=&quot;cursor-default&quot;
        title=&quot;coolrepo / src / tests&quot;
      &gt;
        ...
      &lt;/span&gt;
    &lt;/nav&gt;
  &lt;/div&gt;
&lt;/body&gt;
 ❯ Object.getElementError node_modules/@.../dom/dist/config.js:37:19
 ❯ node_modules/@.../dom/dist/query-helpers.js:76:38
 ❯ node_modules/@.../dom/dist/query-helpers.js:52:17
 ❯ node_modules/@.../dom/dist/query-helpers.js:95:19
 ❯ .../ContentsTable/FileBreadcrumb/FileBreadcrumb.test.jsx:30:27

To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard

Test Failures Detected: Due to failing tests, we cannot provide coverage reports at this time.

:x: Failed Test Results:

Completed 1180 tests with 1 failed, 1179 passed and 0 skipped.

View the full list of failed tests

src/ui/Breadcrumb/Breadcrumb.test.tsx

  • Class name: src/ui/Breadcrumb/Breadcrumb.test.tsx
    Test name: Breadcrumb > Renders breadcrumb > renders a link with the right URL

    TypeError: Cannot read properties of undefined (reading 'length')
    ❯ map .../ui/Breadcrumb/Breadcrumb.tsx:45:50
    ❯ calculateVisibleItems .../ui/Breadcrumb/Breadcrumb.tsx:43:7
    ❯ .../ui/Breadcrumb/Breadcrumb.tsx:68:12
    ❯ commitHookEffectListMount .../react-dom/cjs/react-dom.development.js:23189:26
    ❯ commitPassiveMountOnFiber .../react-dom/cjs/react-dom.development.js:24970:11
    ❯ commitPassiveMountEffects_complete .../react-dom/cjs/react-dom.development.js:24930:9
    ❯ commitPassiveMountEffects_begin .../react-dom/cjs/react-dom.development.js:24917:7
    ❯ commitPassiveMountEffects .../react-dom/cjs/react-dom.development.js:24905:3
    ❯ flushPassiveEffectsImpl .../react-dom/cjs/react-dom.development.js:27078:3

codecov-public-qa[bot] avatar Oct 05 '24 02:10 codecov-public-qa[bot]

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Storybook

Commit Created Cloud Enterprise
ede2e9ed081880560534a4277a59663ffc9be318 Sat, 05 Oct 2024 02:54:51 GMT Expired Expired
711739a6aa8794a0bf2f47b1c1cb2495951ae2e7 Wed, 09 Oct 2024 21:54:44 GMT Expired Expired
7106dea70f08d93e9f5cfcf4375b5487b4989d05 Thu, 17 Oct 2024 16:54:47 GMT Cloud Enterprise

codecov-releaser avatar Oct 05 '24 02:10 codecov-releaser

Bundle Report

Changes will increase total bundle size by 68.4kB (0.41%) :arrow_up:. This is within the configured threshold :white_check_mark:

Detailed changes
Bundle name Size Change
gazebo-staging-system 5.23MB 68.4kB (1.32%) :arrow_up:

codecov-staging[bot] avatar Oct 09 '24 21:10 codecov-staging[bot]