gazebo icon indicating copy to clipboard operation
gazebo copied to clipboard

Hackweek: Codecov Dark Mode

Open ajay-sentry opened this issue 1 year ago • 7 comments
trafficstars

Description

Code Example

Notable Changes

Screenshots

Link to Sample Entry

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

ajay-sentry avatar Aug 17 '24 15:08 ajay-sentry

Bundle Report

Changes will increase total bundle size by 275.79kB :arrow_up:

Bundle name Size Change
gazebo-staging-array-push 5.98MB 275.79kB :arrow_up:

codecov-staging[bot] avatar Aug 17 '24 15:08 codecov-staging[bot]

Codecov Report

Attention: Patch coverage is 98.14815% with 2 lines in your changes missing coverage. Please review.

Project coverage is 98.26%. Comparing base (2a9f213) to head (b02f732).

:white_check_mark: All tests successful. No failed tests found.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3136      +/-   ##
==========================================
- Coverage   98.29%   98.26%   -0.04%     
==========================================
  Files         925      932       +7     
  Lines       14377    14448      +71     
  Branches     3918     3934      +16     
==========================================
+ Hits        14132    14197      +65     
- Misses        240      246       +6     
  Partials        5        5              
Files Coverage Δ
src/App.tsx 100.00% <ø> (ø)
src/assets/providers/sentry-icon-white.svg 50.00% <100.00%> (ø)
.../assets/svg/onboardingTests/testsPRCommentDark.svg 50.00% <ø> (ø)
.../InstallationHelpBanner/InstallationHelpBanner.jsx 100.00% <ø> (ø)
src/layouts/Header/Header.tsx 100.00% <100.00%> (ø)
...outs/Header/components/GuestHeader/GuestHeader.tsx 100.00% <100.00%> (ø)
...ts/Header/components/HelpDropdown/HelpDropdown.tsx 100.00% <100.00%> (ø)
...outs/Header/components/ThemeToggle/ThemeToggle.tsx 100.00% <100.00%> (ø)
src/layouts/LoginLayout/LoginLayout.tsx 100.00% <100.00%> (ø)
...ared/NetworkErrorBoundary/NetworkErrorBoundary.jsx 100.00% <ø> (ø)
... and 100 more

... and 2 files with indirect coverage changes

Components Coverage Δ
Assets 53.48% <66.66%> (-0.57%) :arrow_down:
Layouts 98.87% <100.00%> (+0.06%) :arrow_up:
Pages 99.03% <100.00%> (+<0.01%) :arrow_up:
Services 99.44% <ø> (ø)
Shared 99.71% <100.00%> (+<0.01%) :arrow_up:
UI 94.60% <100.00%> (+0.02%) :arrow_up:

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2a9f213...b02f732. Read the comment docs.

codecov-public-qa[bot] avatar Aug 17 '24 15:08 codecov-public-qa[bot]

Codecov Report

Attention: Patch coverage is 98.14815% with 2 lines in your changes missing coverage. Please review.

:white_check_mark: All tests successful. No failed tests found.

Files Patch % Lines
src/assets/providers/github-icon-white.svg 50.00% 2 Missing :warning:

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3136      +/-   ##
==========================================
- Coverage   98.29%   98.26%   -0.04%     
==========================================
  Files         925      932       +7     
  Lines       14377    14448      +71     
  Branches     3913     3852      -61     
==========================================
+ Hits        14132    14197      +65     
- Misses        240      246       +6     
  Partials        5        5              
Files Coverage Δ
src/App.tsx 100.00% <ø> (ø)
src/assets/providers/sentry-icon-white.svg 50.00% <100.00%> (ø)
.../assets/svg/onboardingTests/testsPRCommentDark.svg 50.00% <ø> (ø)
.../InstallationHelpBanner/InstallationHelpBanner.jsx 100.00% <ø> (ø)
src/layouts/Header/Header.tsx 100.00% <100.00%> (ø)
...outs/Header/components/GuestHeader/GuestHeader.tsx 100.00% <100.00%> (ø)
...ts/Header/components/HelpDropdown/HelpDropdown.tsx 100.00% <100.00%> (ø)
...outs/Header/components/ThemeToggle/ThemeToggle.tsx 100.00% <100.00%> (ø)
src/layouts/LoginLayout/LoginLayout.tsx 100.00% <100.00%> (ø)
...ared/NetworkErrorBoundary/NetworkErrorBoundary.jsx 100.00% <ø> (ø)
... and 100 more

... and 2 files with indirect coverage changes

Components Coverage Δ
Assets 53.48% <66.66%> (-0.57%) :arrow_down:
Layouts 98.87% <100.00%> (+0.06%) :arrow_up:
Pages 99.03% <100.00%> (+<0.01%) :arrow_up:
Services 99.44% <ø> (ø)
Shared 99.71% <100.00%> (+<0.01%) :arrow_up:
UI 94.60% <100.00%> (+0.02%) :arrow_up:

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2a9f213...b02f732. Read the comment docs.

Codecov Report

Attention: Patch coverage is 98.14815% with 2 lines in your changes missing coverage. Please review.

Project coverage is 98.26%. Comparing base (2a9f213) to head (b02f732). Report is 1 commits behind head on main.

:white_check_mark: All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/assets/providers/github-icon-white.svg 50.00% 2 Missing :warning:

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3136      +/-   ##
==========================================
- Coverage   98.29%   98.26%   -0.04%     
==========================================
  Files         925      932       +7     
  Lines       14377    14448      +71     
  Branches     3831     3852      +21     
==========================================
+ Hits        14132    14197      +65     
- Misses        240      246       +6     
  Partials        5        5              
Files with missing lines Coverage Δ
src/App.tsx 100.00% <ø> (ø)
src/assets/providers/sentry-icon-white.svg 50.00% <100.00%> (ø)
.../assets/svg/onboardingTests/testsPRCommentDark.svg 50.00% <ø> (ø)
.../InstallationHelpBanner/InstallationHelpBanner.jsx 100.00% <ø> (ø)
src/layouts/Header/Header.tsx 100.00% <100.00%> (ø)
...outs/Header/components/GuestHeader/GuestHeader.tsx 100.00% <100.00%> (ø)
...ts/Header/components/HelpDropdown/HelpDropdown.tsx 100.00% <100.00%> (ø)
...outs/Header/components/ThemeToggle/ThemeToggle.tsx 100.00% <100.00%> (ø)
src/layouts/LoginLayout/LoginLayout.tsx 100.00% <100.00%> (ø)
...ared/NetworkErrorBoundary/NetworkErrorBoundary.jsx 100.00% <ø> (ø)
... and 100 more

... and 2 files with indirect coverage changes

Components Coverage Δ
Assets 53.48% <66.66%> (-0.57%) :arrow_down:
Layouts 98.87% <100.00%> (+0.06%) :arrow_up:
Pages 99.03% <100.00%> (+<0.01%) :arrow_up:
Services 99.44% <ø> (ø)
Shared 99.71% <100.00%> (+<0.01%) :arrow_up:
UI 94.60% <100.00%> (+0.02%) :arrow_up:

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2a9f213...b02f732. Read the comment docs.

codecov-qa[bot] avatar Aug 17 '24 15:08 codecov-qa[bot]

Codecov Report

Attention: Patch coverage is 98.14815% with 2 lines in your changes missing coverage. Please review.

Project coverage is 98.26%. Comparing base (2a9f213) to head (b02f732). Report is 1 commits behind head on main.

:white_check_mark: All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/assets/providers/github-icon-white.svg 50.00% 2 Missing :warning:
Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff                @@
##               main      #3136        +/-   ##
================================================
- Coverage   98.29000   98.26000   -0.03000     
================================================
  Files           925        932         +7     
  Lines         14377      14448        +71     
  Branches       3886       3907        +21     
================================================
+ Hits          14132      14197        +65     
- Misses          240        246         +6     
  Partials          5          5                
Files with missing lines Coverage Δ
src/App.tsx 100.00% <ø> (ø)
src/assets/providers/sentry-icon-white.svg 50.00% <100.00%> (ø)
.../assets/svg/onboardingTests/testsPRCommentDark.svg 50.00% <ø> (ø)
.../InstallationHelpBanner/InstallationHelpBanner.jsx 100.00% <ø> (ø)
src/layouts/Header/Header.tsx 100.00% <100.00%> (ø)
...outs/Header/components/GuestHeader/GuestHeader.tsx 100.00% <100.00%> (ø)
...ts/Header/components/HelpDropdown/HelpDropdown.tsx 100.00% <100.00%> (ø)
...outs/Header/components/ThemeToggle/ThemeToggle.tsx 100.00% <100.00%> (ø)
src/layouts/LoginLayout/LoginLayout.tsx 100.00% <100.00%> (ø)
...ared/NetworkErrorBoundary/NetworkErrorBoundary.jsx 100.00% <ø> (ø)
... and 100 more

... and 2 files with indirect coverage changes

Components Coverage Δ
Assets 53.48% <66.66%> (-0.57%) :arrow_down:
Layouts 98.87% <100.00%> (+0.06%) :arrow_up:
Pages 99.03% <100.00%> (+<0.01%) :arrow_up:
Services 99.44% <ø> (ø)
Shared 99.71% <100.00%> (+<0.01%) :arrow_up:
UI 94.60% <100.00%> (+0.02%) :arrow_up:

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2a9f213...b02f732. Read the comment docs.

codecov[bot] avatar Aug 17 '24 15:08 codecov[bot]

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Storybook

Commit Created Cloud Enterprise
cd6174547a996f7f68191ae4f1d638f2913df442 Sat, 17 Aug 2024 15:40:50 GMT Expired Expired
8ca1a8943c244228626dd143361ef99c49ec4408 Mon, 19 Aug 2024 16:56:53 GMT Expired Expired
d1104b3547cbeb6a5d7a2c5ecba4e2f435a44bcb Mon, 19 Aug 2024 18:48:14 GMT Expired Expired
0e3d02bdd30dcc2b8554dfd8606caf239a9d2791 Mon, 19 Aug 2024 19:46:42 GMT Expired Expired
4be9020ae2f5ea481f2c4a73a1be1fd51dd8e321 Mon, 19 Aug 2024 20:07:36 GMT Expired Expired
4be9020ae2f5ea481f2c4a73a1be1fd51dd8e321 Mon, 19 Aug 2024 20:09:40 GMT Expired Expired
6113e7ad4524ad08a03fb89a0ec0e0279d0032f0 Mon, 19 Aug 2024 20:31:35 GMT Expired Expired
b517a869f80e9e539da09da6539cadc04ea78366 Mon, 19 Aug 2024 20:39:01 GMT Expired Expired
8b11a0f3d8b861adaa6ac73549c114f3c5f06143 Mon, 19 Aug 2024 20:56:04 GMT Expired Expired
7a6707f6a6f9a6122491ca47fed3bc0037f88441 Mon, 19 Aug 2024 22:51:16 GMT Expired Expired
d64d35e20442f8b92e97306c1dfb52366310c1ea Mon, 19 Aug 2024 23:13:03 GMT Expired Expired
3b2b691c7753eef404dce47af21013ff7a77f2cc Mon, 19 Aug 2024 23:33:31 GMT Expired Expired
aa8b3eda7de15ac9c6a011fd7bf019756fd5e2d2 Mon, 19 Aug 2024 23:52:42 GMT Expired Expired
5c449b6a8c1b083b976ad0c05d58e3daca999fc7 Tue, 20 Aug 2024 14:55:41 GMT Expired Expired
5c449b6a8c1b083b976ad0c05d58e3daca999fc7 Tue, 20 Aug 2024 14:57:24 GMT Expired Expired
aa8f8edfe9bf01017525bcd3296951121e42c1b6 Tue, 20 Aug 2024 15:27:29 GMT Expired Expired
95182a2d1052f5b0caff2c1f7a1fffdf7815e4a3 Tue, 20 Aug 2024 15:59:06 GMT Expired Expired
bcdb27d3a5a013654dee7647e74658eda91e354d Tue, 20 Aug 2024 17:12:23 GMT Expired Expired
26d2727edc9e36379a1509fa0ab24492edf44a38 Tue, 20 Aug 2024 18:54:45 GMT Expired Expired
26d2727edc9e36379a1509fa0ab24492edf44a38 Tue, 20 Aug 2024 18:56:06 GMT Expired Expired
4760016480030bb6c6c6c9fa38ff23e005861fe7 Tue, 20 Aug 2024 19:14:58 GMT Expired Expired
49608f1e95638429e08b9e03a2ea0e65c76bb1f4 Tue, 20 Aug 2024 21:07:54 GMT Expired Expired
49608f1e95638429e08b9e03a2ea0e65c76bb1f4 Tue, 20 Aug 2024 21:09:25 GMT Expired Expired
91c6b520e6ccd24a736d7312ad7e6545a7caf7d4 Tue, 20 Aug 2024 21:39:39 GMT Expired Expired
dea52a6bbd1396f0673158414e82c47b00c7a668 Tue, 20 Aug 2024 21:50:25 GMT Expired Expired
0ac7c1745b21f3fd770ec686d1f30d7348ffa36a Tue, 20 Aug 2024 22:12:44 GMT Expired Expired
f9e61d08b755a659ac309c7f1b87ab7eee868c46 Tue, 20 Aug 2024 23:04:04 GMT Expired Expired
a8e62007c5f7d02e17fc12fa20da994c6d2a6819 Tue, 20 Aug 2024 23:42:48 GMT Expired Expired
a8e62007c5f7d02e17fc12fa20da994c6d2a6819 Tue, 20 Aug 2024 23:47:30 GMT Expired Expired
a8e62007c5f7d02e17fc12fa20da994c6d2a6819 Tue, 20 Aug 2024 23:48:38 GMT Expired Expired
4287930b8652230b2a65236f10e66b581e435ac8 Wed, 21 Aug 2024 15:36:49 GMT Expired Expired
4f23bf647ce8c4cac4034dbad0b8733ca7a6105f Wed, 21 Aug 2024 15:53:01 GMT Expired Expired
4f23bf647ce8c4cac4034dbad0b8733ca7a6105f Wed, 21 Aug 2024 15:56:17 GMT Expired Expired
78b23df872e5d2972a8722673e585892fa4e2be0 Wed, 21 Aug 2024 17:22:18 GMT Expired Expired
d707e99820b796fc303c20522d5da45100e2a126 Wed, 21 Aug 2024 18:21:45 GMT Expired Expired
ac84ce2df81a2c9999d408122b09d99146a2f145 Wed, 21 Aug 2024 18:33:41 GMT Expired Expired
993d7455a7ec917981473abc367184b16b0b10b9 Wed, 21 Aug 2024 18:44:26 GMT Expired Expired
993d7455a7ec917981473abc367184b16b0b10b9 Wed, 21 Aug 2024 18:50:06 GMT Expired Expired
16972cc0a7f307b172c2bbd3ee624c144f5e531c Wed, 21 Aug 2024 19:04:09 GMT Expired Expired
d3b9efd6150797ad965e81295107306d5376385c Wed, 21 Aug 2024 19:11:07 GMT Expired Expired
5f834e3ac02c1d1cfcac9893735620fc62534516 Wed, 21 Aug 2024 19:20:05 GMT Expired Expired
9be97b64444c732eee748f8d38798a5aced7e3f9 Wed, 21 Aug 2024 19:51:05 GMT Expired Expired
f4e3bdf1ac2cd837fa22198b9d458797c6856250 Wed, 21 Aug 2024 20:06:31 GMT Expired Expired
80d597e9693dd83d7bb720fabc2fcd11280ec56c Wed, 21 Aug 2024 21:05:29 GMT Expired Expired
08c409fe6ad745a762388ae42ac6f176b0e3f3a0 Wed, 21 Aug 2024 21:28:19 GMT Expired Expired
c4a9a1041147d8ba34cc8565ef9e19c8be12b4ce Wed, 21 Aug 2024 22:43:29 GMT Expired Expired
c4a9a1041147d8ba34cc8565ef9e19c8be12b4ce Wed, 21 Aug 2024 22:45:12 GMT Expired Expired
f1b8aa853cc2861835956cf90b746546478c18c5 Wed, 21 Aug 2024 22:55:43 GMT Expired Expired
9db432ec0a3825fec2e9d78c4592f2bf38597e12 Thu, 22 Aug 2024 02:25:53 GMT Expired Expired
e345f3072f2548b00db77ed0ff75683569118964 Thu, 22 Aug 2024 03:57:50 GMT Expired Expired
1b654785dfa305fe9334847001b7470e2fbe2e5d Thu, 22 Aug 2024 04:17:21 GMT Expired Expired
38de231d203a48293682cfcaa30cf10842595920 Thu, 22 Aug 2024 05:21:03 GMT Expired Expired
f70508ef6b47b1b5283c4ac456d3529fd32a7751 Thu, 22 Aug 2024 15:28:37 GMT Expired Expired
8eada656810e356ed3cd534d52da41797411ad87 Thu, 22 Aug 2024 18:06:54 GMT Expired Expired
bd8115e6bd1a685bbda9b2573eca78e18e613301 Thu, 22 Aug 2024 18:20:25 GMT Expired Expired
4f35c178e9e523869ccf33893bda2300dd9aae64 Thu, 22 Aug 2024 18:31:06 GMT Expired Expired
36abb5f995fe31d45f150377f1a603c6626e0055 Thu, 22 Aug 2024 22:06:32 GMT Expired Expired
efdc6b853fe3712b964eeb1fd5cef4da1176aa71 Thu, 22 Aug 2024 22:53:54 GMT Expired Expired
efdc6b853fe3712b964eeb1fd5cef4da1176aa71 Thu, 22 Aug 2024 22:59:05 GMT Expired Expired
634b5ab9c2268702f9b9472844c0086c79eb1e35 Thu, 22 Aug 2024 23:48:49 GMT Expired Expired
f10086b3717c1218b2db54908c65594b9c292085 Sun, 25 Aug 2024 16:09:55 GMT Expired Expired
98aadf7a0b663a5be89322682f6b7fd9a0a185f3 Mon, 26 Aug 2024 15:54:21 GMT Expired Expired
de87f6171426b50df69d6851d129a9d16ec6e215 Mon, 26 Aug 2024 17:02:49 GMT Expired Expired
15a6f3b64bbe4a05f0e45e9bf7f0fbcdf83f1f20 Mon, 26 Aug 2024 18:13:48 GMT Expired Expired
46c6c2af961c47a7cdb7313ef28d3285ffdb6fcd Mon, 26 Aug 2024 19:42:37 GMT Expired Expired
14316bfd3a22cb19f79ee7161022050744a5a327 Mon, 26 Aug 2024 23:32:12 GMT Expired Expired
14316bfd3a22cb19f79ee7161022050744a5a327 Mon, 26 Aug 2024 23:34:43 GMT Expired Expired
14316bfd3a22cb19f79ee7161022050744a5a327 Mon, 26 Aug 2024 23:37:42 GMT Expired Expired
27e23d03913812abff8d01b2bdec1aefbebf8b9a Tue, 27 Aug 2024 01:21:25 GMT Expired Expired
817eaa52d63d1254baff855022765cec55cbc3f8 Tue, 27 Aug 2024 05:12:48 GMT Expired Expired
5ab04da6708d21458703b0f33f86e1be729684cb Tue, 27 Aug 2024 18:29:46 GMT Expired Expired
c2626af3e97fafe48ac24449a60df258ceb2e9d4 Tue, 27 Aug 2024 20:15:06 GMT Expired Expired
46c1c45ed91416d3562dc7f85cc3ad292ea38e9e Tue, 27 Aug 2024 23:28:34 GMT Expired Expired
ab33d8e3997e01e1edc59ed9765825271e0e08b6 Wed, 28 Aug 2024 01:23:14 GMT Expired Expired
4a96955744a3dc740fc35c75dc487c24082a52c5 Wed, 28 Aug 2024 16:11:24 GMT Expired Expired
232fece20d7e4ec637f39fd420d5d6f3197d499b Thu, 29 Aug 2024 18:18:45 GMT Expired Expired
232fece20d7e4ec637f39fd420d5d6f3197d499b Thu, 29 Aug 2024 18:22:31 GMT Expired Expired
cc9096d69cdf0e44c066219fec0f185097f3c2a9 Thu, 29 Aug 2024 18:49:45 GMT Expired Expired
87739a9a369e987765787c6c5f677192417ac577 Tue, 03 Sep 2024 20:55:18 GMT Expired Expired
d95694a8f76dcf5d3f120314467fe149988d4443 Tue, 03 Sep 2024 21:10:46 GMT Expired Expired
b02f73253a950cdfb62ac108ed65175054a64006 Tue, 03 Sep 2024 21:44:01 GMT Cloud Enterprise

codecov-releaser avatar Aug 17 '24 15:08 codecov-releaser

Bundle Report

Changes will increase total bundle size by 275.79kB :arrow_up:

Bundle name Size Change
gazebo-production-array-push 5.98MB 275.79kB :arrow_up:

codecov[bot] avatar Aug 19 '24 16:08 codecov[bot]

Sorry forgot to ask this question before, can we add in support to default to whatever the default in the system is set to?

nicholas-codecov avatar Aug 27 '24 12:08 nicholas-codecov

Sorry forgot to ask this question before, can we add in support to default to whatever the default in the system is set to?

@nicholas-codecov yep that's a commented out section currently in the globals.css file. We didn't have a good way to feature flag it so we disabled it altogether for the initial launch. Should be an easy add later on

ajay-sentry avatar Aug 27 '24 15:08 ajay-sentry

TODO - good suggestion from Nick to check if we have access to local storage before read/write to avoid Sentry errors that have been coming through related to that

looks like this is a bit larger effort without immediate impact to block this.. spun this off - https://github.com/codecov/engineering-team/issues/2454

Seems like if we want to do some try/catch around the localStorage.get/set, may need an error banner or something to show up to let the user know the themeToggle was unsuccessful. But from what I can tell, codecov app can't be logged into at all when users have access to localStorage off.. So may try to address this in the separate Issue above.

suejung-sentry avatar Aug 29 '24 19:08 suejung-sentry