gazebo icon indicating copy to clipboard operation
gazebo copied to clipboard

Published 20 hours ago • verified publisher icon codecov

feat: Handle activation alert in failed tests page

Open RulaKhaled opened this issue 1 year ago • 6 comments
trafficstars

Description

As we roll out new features such as bundle and failed tests and when they become part of a paid plan, these areas should have the same conditional trial offering and/or upgrade UX. This means if the plan is private/unpaid and/or seats not activate the same communication is made across the features.

This PR renders activation alert in failed tests page when user is not activated and current repo is private

Notable Changes

  • Removed the unnecessary owner not activated union type
  • Added is current user activated field to repo overview
  • Fixed tests
  • Actually rendered the activation alert in the failed tests tab

Screenshots

Screenshot 2024-08-16 at 2 21 35 PM

issue: https://github.com/codecov/engineering-team/issues/1689

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

RulaKhaled avatar Aug 16 '24 12:08 RulaKhaled

Bundle Report

Changes will increase total bundle size by 47 bytes :arrow_up:

Bundle name Size Change
gazebo-production-array-push 5.71MB 47 bytes :arrow_up:

codecov[bot] avatar Aug 16 '24 12:08 codecov[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 98.29%. Comparing base (703b34b) to head (72fd86f).

:white_check_mark: All tests successful. No failed tests found.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3133      +/-   ##
==========================================
- Coverage   98.31%   98.29%   -0.02%     
==========================================
  Files         923      923              
  Lines       14400    14393       -7     
  Branches     3855     3932      +77     
==========================================
- Hits        14157    14148       -9     
- Misses        238      240       +2     
  Partials        5        5
Files Coverage Δ
...c/pages/RepoPage/FailedTestsTab/FailedTestsTab.tsx 93.33% <100.00%> (+1.02%) :arrow_up:
src/pages/RepoPage/RepoPage.tsx 100.00% <100.00%> (ø)
src/pages/RepoPage/RepoPageTabs.tsx 100.00% <100.00%> (ø)
src/services/repo/useRepoOverview.tsx 96.66% <ø> (-3.34%) :arrow_down:

... and 1 file with indirect coverage changes

Components Coverage Δ
Assets 54.05% <ø> (ø)
Layouts 98.80% <ø> (ø)
Pages 99.03% <100.00%> (-0.01%) :arrow_down:
Services 99.44% <ø> (-0.07%) :arrow_down:
Shared 99.71% <ø> (ø)
UI 94.51% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 703b34b...72fd86f. Read the comment docs.

codecov-public-qa[bot] avatar Aug 16 '24 12:08 codecov-public-qa[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

:white_check_mark: All tests successful. No failed tests found.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3133      +/-   ##
==========================================
- Coverage   98.31%   98.29%   -0.02%     
==========================================
  Files         923      923              
  Lines       14400    14393       -7     
  Branches     3941     3851      -90     
==========================================
- Hits        14157    14148       -9     
- Misses        238      240       +2     
  Partials        5        5
Files Coverage Δ
...c/pages/RepoPage/FailedTestsTab/FailedTestsTab.tsx 93.33% <100.00%> (+1.02%) :arrow_up:
src/pages/RepoPage/RepoPage.tsx 100.00% <100.00%> (ø)
src/pages/RepoPage/RepoPageTabs.tsx 100.00% <100.00%> (ø)
src/services/repo/useRepoOverview.tsx 96.66% <ø> (-3.34%) :arrow_down:

... and 1 file with indirect coverage changes

Components Coverage Δ
Assets 54.05% <ø> (ø)
Layouts 98.80% <ø> (ø)
Pages 99.03% <100.00%> (-0.01%) :arrow_down:
Services 99.44% <ø> (-0.07%) :arrow_down:
Shared 99.71% <ø> (ø)
UI 94.51% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 703b34b...72fd86f. Read the comment docs.

codecov-notifications[bot] avatar Aug 16 '24 12:08 codecov-notifications[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 98.29%. Comparing base (703b34b) to head (72fd86f). Report is 1 commits behind head on main.

:white_check_mark: All tests successful. No failed tests found.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3133      +/-   ##
==========================================
- Coverage   98.31%   98.29%   -0.02%     
==========================================
  Files         923      923              
  Lines       14400    14393       -7     
  Branches     3910     3937      +27     
==========================================
- Hits        14157    14148       -9     
- Misses        238      240       +2     
  Partials        5        5
Files Coverage Δ
...c/pages/RepoPage/FailedTestsTab/FailedTestsTab.tsx 93.33% <100.00%> (+1.02%) :arrow_up:
src/pages/RepoPage/RepoPage.tsx 100.00% <100.00%> (ø)
src/pages/RepoPage/RepoPageTabs.tsx 100.00% <100.00%> (ø)
src/services/repo/useRepoOverview.tsx 96.66% <ø> (-3.34%) :arrow_down:

... and 1 file with indirect coverage changes

Components Coverage Δ
Assets 54.05% <ø> (ø)
Layouts 98.80% <ø> (ø)
Pages 99.03% <100.00%> (-0.01%) :arrow_down:
Services 99.44% <ø> (-0.07%) :arrow_down:
Shared 99.71% <ø> (ø)
UI 94.51% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 703b34b...72fd86f. Read the comment docs.

codecov-qa[bot] avatar Aug 16 '24 12:08 codecov-qa[bot]

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Storybook

Commit Created Cloud Enterprise
698023010e78256f89972801da85e6b1872e2535 Fri, 16 Aug 2024 12:18:24 GMT Expired Expired
72fd86f943ffb3bec361bd31a831261861ccd486 Wed, 28 Aug 2024 09:13:07 GMT Cloud Enterprise

codecov-releaser avatar Aug 16 '24 12:08 codecov-releaser

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 98.29%. Comparing base (703b34b) to head (72fd86f). Report is 1 commits behind head on main.

:white_check_mark: All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff                @@
##               main      #3133        +/-   ##
================================================
- Coverage   98.31000   98.29000   -0.02000     
================================================
  Files           923        923                
  Lines         14400      14393         -7     
  Branches       3910       3932        +22     
================================================
- Hits          14157      14148         -9     
- Misses          238        240         +2     
  Partials          5          5
Files Coverage Δ
...c/pages/RepoPage/FailedTestsTab/FailedTestsTab.tsx 93.33% <100.00%> (+1.02%) :arrow_up:
src/pages/RepoPage/RepoPage.tsx 100.00% <100.00%> (ø)
src/pages/RepoPage/RepoPageTabs.tsx 100.00% <100.00%> (ø)
src/services/repo/useRepoOverview.tsx 96.66% <ø> (-3.34%) :arrow_down:

... and 1 file with indirect coverage changes

Components Coverage Δ
Assets 54.05% <ø> (ø)
Layouts 98.80% <ø> (ø)
Pages 99.03% <100.00%> (-0.01%) :arrow_down:
Services 99.44% <ø> (-0.07%) :arrow_down:
Shared 99.71% <ø> (ø)
UI 94.51% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 703b34b...72fd86f. Read the comment docs.

codecov[bot] avatar Aug 16 '24 12:08 codecov[bot]

Bundle Report

Changes will increase total bundle size by 47 bytes :arrow_up:

Bundle name Size Change
gazebo-staging-array-push 5.71MB 47 bytes :arrow_up:

codecov-staging[bot] avatar Aug 27 '24 11:08 codecov-staging[bot]