gazebo icon indicating copy to clipboard operation
gazebo copied to clipboard

fix: Set correct scroll margin in new file renderer

Open nicholas-codecov opened this issue 1 year ago • 7 comments

Description

The current scroll margin isn't being correctly set, so this PR updates this, by setting the correct scroll margin in our once off useLayoutEffect that will set the correct height.

Notable Changes

  • Set the correct scroll margin in the new renderer.

nicholas-codecov avatar Aug 15 '24 16:08 nicholas-codecov

Bundle Report

Changes will decrease total bundle size by 80.49kB :arrow_down:

Bundle name Size Change
gazebo-production-array-push 5.77MB 80.49kB :arrow_down:

codecov[bot] avatar Aug 15 '24 16:08 codecov[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

:white_check_mark: All tests successful. No failed tests found.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3130      +/-   ##
==========================================
- Coverage   98.31%   98.30%   -0.01%     
==========================================
  Files         917      919       +2     
  Lines       14152    14187      +35     
  Branches     3922     3923       +1     
==========================================
+ Hits        13913    13947      +34     
- Misses        234      235       +1     
  Partials        5        5              
Files Coverage Δ
src/ui/VirtualFileRenderer/VirtualFileRenderer.tsx 99.11% <100.00%> (-0.89%) :arrow_down:

... and 8 files with indirect coverage changes

Components Coverage Δ
Assets 54.05% <ø> (ø)
Layouts 98.80% <ø> (ø)
Pages 99.03% <ø> (ø)
Services 99.51% <ø> (+<0.01%) :arrow_up:
Shared 99.71% <ø> (+<0.01%) :arrow_up:
UI 94.51% <100.00%> (-0.03%) :arrow_down:

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 162d85d...f450209. Read the comment docs.

codecov-staging[bot] avatar Aug 15 '24 16:08 codecov-staging[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 98.30%. Comparing base (162d85d) to head (f450209). Report is 6 commits behind head on main.

:white_check_mark: All tests successful. No failed tests found.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3130      +/-   ##
==========================================
- Coverage   98.31%   98.30%   -0.01%     
==========================================
  Files         917      919       +2     
  Lines       14152    14187      +35     
  Branches     3836     3842       +6     
==========================================
+ Hits        13913    13947      +34     
- Misses        234      235       +1     
  Partials        5        5              
Files Coverage Δ
src/ui/VirtualFileRenderer/VirtualFileRenderer.tsx 99.11% <100.00%> (-0.89%) :arrow_down:

... and 8 files with indirect coverage changes

Components Coverage Δ
Assets 54.05% <ø> (ø)
Layouts 98.80% <ø> (ø)
Pages 99.03% <ø> (ø)
Services 99.51% <ø> (+<0.01%) :arrow_up:
Shared 99.71% <ø> (+<0.01%) :arrow_up:
UI 94.51% <100.00%> (-0.03%) :arrow_down:

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 162d85d...f450209. Read the comment docs.

codecov-qa[bot] avatar Aug 15 '24 16:08 codecov-qa[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 98.30%. Comparing base (162d85d) to head (f450209). Report is 5 commits behind head on main.

:white_check_mark: All tests successful. No failed tests found.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3130      +/-   ##
==========================================
- Coverage   98.31%   98.30%   -0.01%     
==========================================
  Files         917      919       +2     
  Lines       14152    14187      +35     
  Branches     3922     3842      -80     
==========================================
+ Hits        13913    13947      +34     
- Misses        234      235       +1     
  Partials        5        5              
Files Coverage Δ
src/ui/VirtualFileRenderer/VirtualFileRenderer.tsx 99.11% <100.00%> (-0.89%) :arrow_down:

... and 8 files with indirect coverage changes

Components Coverage Δ
Assets 54.05% <ø> (ø)
Layouts 98.80% <ø> (ø)
Pages 99.03% <ø> (ø)
Services 99.51% <ø> (+<0.01%) :arrow_up:
Shared 99.71% <ø> (+<0.01%) :arrow_up:
UI 94.51% <100.00%> (-0.03%) :arrow_down:

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 162d85d...f450209. Read the comment docs.

codecov-public-qa[bot] avatar Aug 15 '24 16:08 codecov-public-qa[bot]

Bundle Report

Changes will decrease total bundle size by 80.49kB :arrow_down:

Bundle name Size Change
gazebo-staging-array-push 5.77MB 80.49kB :arrow_down:

codecov-staging[bot] avatar Aug 15 '24 16:08 codecov-staging[bot]

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Storybook

Commit Created Cloud Enterprise
b51b568dc0e0bb81b2d1f189e1173923473ae517 Thu, 15 Aug 2024 16:17:26 GMT Expired Expired
8f4b10fdb45f27970b454ea5e1ed55074960b8f1 Thu, 15 Aug 2024 16:58:14 GMT Expired Expired
abe53c3bc563a0991e9dcd336c696a4e7b24fae3 Mon, 19 Aug 2024 21:33:52 GMT Expired Expired
7c7d18e0e851e66b8acebde118959ae2386f3718 Tue, 20 Aug 2024 10:37:48 GMT Expired Expired
dffe93f49afa36560b51cc399fe59b9f821d5a80 Tue, 20 Aug 2024 10:47:22 GMT Expired Expired
f450209e9241e04b8c15a314ad155abd759ef3c7 Tue, 20 Aug 2024 16:09:24 GMT Cloud Enterprise

codecov-releaser avatar Aug 15 '24 16:08 codecov-releaser

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 98.30%. Comparing base (162d85d) to head (f450209). Report is 6 commits behind head on main.

:white_check_mark: All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff                @@
##               main      #3130        +/-   ##
================================================
- Coverage   98.31000   98.30000   -0.01000     
================================================
  Files           917        919         +2     
  Lines         14152      14187        +35     
  Branches       3891       3842        -49     
================================================
+ Hits          13913      13947        +34     
- Misses          234        235         +1     
  Partials          5          5                
Files Coverage Δ
src/ui/VirtualFileRenderer/VirtualFileRenderer.tsx 99.11% <100.00%> (-0.89%) :arrow_down:

... and 8 files with indirect coverage changes

Components Coverage Δ
Assets 54.05% <ø> (ø)
Layouts 98.80% <ø> (ø)
Pages 99.03% <ø> (ø)
Services 99.51% <ø> (+<0.01%) :arrow_up:
Shared 99.71% <ø> (+<0.01%) :arrow_up:
UI 94.51% <100.00%> (-0.03%) :arrow_down:

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 162d85d...f450209. Read the comment docs.

codecov[bot] avatar Aug 15 '24 16:08 codecov[bot]

looks good. Tested it out and it does fix the bug I noticed!

spalmurray-codecov avatar Aug 20 '24 18:08 spalmurray-codecov