gazebo icon indicating copy to clipboard operation
gazebo copied to clipboard

fix: content layout shift fix, form label common component, and other changes

Open sashaboi opened this issue 9 months ago • 3 comments

Changes

I have added a few things :

  1. Form Label component : more uniform label for dropdowns
  2. Fix top margin at /account/github/<username> which gave a bit of a content shift for the first tab
  3. Clear filters label horizontal align
  4. Gap between label and dropdown for src/pages/AnalyticsPage/ChartSelectors/ChartSelectors.jsx made uniform
  5. Bundle summary content shift made uniform
  6. Bundles asset table drop down arrow alignment

Description

Video explanation : https://github.com/codecov/gazebo/assets/75421090/3abefbd7-3cd1-4d5f-9452-7c08519f909d

Notable Changes

Addition of FormLabel component & tests

Disclaimer

Most of these are nitpicks but as a frontend person these keep me up at night 💀 Finally found time now to pick these after going through Codecov during my interview at Sentry last month. This is my fun account , I have earlier contributed through @onkardeshpande93

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

sashaboi avatar May 24 '24 21:05 sashaboi