gazebo icon indicating copy to clipboard operation
gazebo copied to clipboard

Published 20 hours ago • verified publisher icon codecov

Show installation help banner in global banners

Open rohitvinnakota-codecov opened this issue 1 year ago • 4 comments
trafficstars

Description

The last change had to be reverted https://github.com/codecov/gazebo/pull/2691 as it failed on null providers. This change adds a check to ensure a provider exists similar to RequestInstallBanner.

  • [x] test on enterprise

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

rohitvinnakota-codecov avatar Mar 14 '24 16:03 rohitvinnakota-codecov

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 98.40%. Comparing base (914245b) to head (a8ce9ab).

:white_check_mark: All tests successful. No failed tests found :relaxed:

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2702   +/-   ##
=======================================
  Coverage   98.40%   98.40%           
=======================================
  Files         885      885           
  Lines       13059    13060    +1     
  Branches     3481     3416   -65     
=======================================
+ Hits        12851    12852    +1     
  Misses        204      204           
  Partials        4        4
Files Coverage Δ
.../InstallationHelpBanner/InstallationHelpBanner.tsx 100.00% <100.00%> (ø)
src/shared/GlobalTopBanners/GlobalTopBanners.tsx 100.00% <ø> (ø)
Components Coverage Δ
Assets 53.84% <ø> (ø)
Layouts 97.23% <100.00%> (+<0.01%) :arrow_up:
Pages 99.23% <ø> (ø)
Services 99.45% <ø> (ø)
Shared 99.68% <ø> (ø)
UI 94.72% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 914245b...a8ce9ab. Read the comment docs.

codecov-public-qa[bot] avatar Mar 14 '24 16:03 codecov-public-qa[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 98.40%. Comparing base (914245b) to head (a8ce9ab).

:white_check_mark: All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2702   +/-   ##
=======================================
  Coverage   98.40%   98.40%           
=======================================
  Files         885      885           
  Lines       13059    13060    +1     
  Branches     3416     3481   +65     
=======================================
+ Hits        12851    12852    +1     
  Misses        204      204           
  Partials        4        4
Files Coverage Δ
.../InstallationHelpBanner/InstallationHelpBanner.tsx 100.00% <100.00%> (ø)
src/shared/GlobalTopBanners/GlobalTopBanners.tsx 100.00% <ø> (ø)
Components Coverage Δ
Assets 53.84% <ø> (ø)
Layouts 97.23% <100.00%> (+<0.01%) :arrow_up:
Pages 99.23% <ø> (ø)
Services 99.45% <ø> (ø)
Shared 99.68% <ø> (ø)
UI 94.72% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 914245b...a8ce9ab. Read the comment docs.

codecov-qa[bot] avatar Mar 14 '24 16:03 codecov-qa[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 98.40%. Comparing base (914245b) to head (a8ce9ab).

:white_check_mark: All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##               main      #2702   +/-   ##
===========================================
  Coverage   98.40000   98.40000           
===========================================
  Files           885        885           
  Lines         13059      13060    +1     
  Branches       3486       3481    -5     
===========================================
+ Hits          12851      12852    +1     
  Misses          204        204           
  Partials          4          4
Files Coverage Δ
.../InstallationHelpBanner/InstallationHelpBanner.tsx 100.00% <100.00%> (ø)
src/shared/GlobalTopBanners/GlobalTopBanners.tsx 100.00% <ø> (ø)
Components Coverage Δ
Assets 53.84% <ø> (ø)
Layouts 97.23% <100.00%> (+<0.01%) :arrow_up:
Pages 99.23% <ø> (ø)
Services 99.45% <ø> (ø)
Shared 99.68% <ø> (ø)
UI 94.72% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 914245b...a8ce9ab. Read the comment docs.

codecov[bot] avatar Mar 14 '24 16:03 codecov[bot]

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Commit Created Cloud Enterprise
ce4fa3d7bbd2136a609d4d0cfbc70e51ddbd0573 Thu, 14 Mar 2024 16:59:43 GMT Expired Expired
ce4fa3d7bbd2136a609d4d0cfbc70e51ddbd0573 Thu, 14 Mar 2024 17:00:35 GMT Expired Expired
ce4fa3d7bbd2136a609d4d0cfbc70e51ddbd0573 Thu, 14 Mar 2024 17:04:53 GMT Expired Expired
ce4fa3d7bbd2136a609d4d0cfbc70e51ddbd0573 Thu, 14 Mar 2024 17:05:12 GMT Expired Expired
ce4fa3d7bbd2136a609d4d0cfbc70e51ddbd0573 Thu, 14 Mar 2024 18:53:23 GMT Expired Expired
a8ce9ab7831fc6ea2de174e668c20e5ac1587c3c Fri, 14 Jun 2024 15:24:11 GMT Cloud Enterprise

codecov-releaser avatar Mar 14 '24 16:03 codecov-releaser

@rohitvinnakota-codecov are we moving forward with this PR, or are we okay to close it out?

nicholas-codecov avatar Jun 14 '24 12:06 nicholas-codecov

Enterprise

Forgot about this one, let's merge it when we can. I tested again just to ensure the app is loading.

rohitvinnakota-codecov avatar Jun 14 '24 15:06 rohitvinnakota-codecov

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

:white_check_mark: All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2702   +/-   ##
=======================================
  Coverage   98.40%   98.40%           
=======================================
  Files         885      885           
  Lines       13059    13060    +1     
  Branches     3486     3463   -23     
=======================================
+ Hits        12851    12852    +1     
  Misses        204      204           
  Partials        4        4
Files Coverage Δ
.../InstallationHelpBanner/InstallationHelpBanner.tsx 100.00% <100.00%> (ø)
src/shared/GlobalTopBanners/GlobalTopBanners.tsx 100.00% <ø> (ø)
Components Coverage Δ
Assets 53.84% <ø> (ø)
Layouts 97.23% <100.00%> (+<0.01%) :arrow_up:
Pages 99.23% <ø> (ø)
Services 99.45% <ø> (ø)
Shared 99.68% <ø> (ø)
UI 94.72% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 914245b...a8ce9ab. Read the comment docs.

codecov-notifications[bot] avatar Jun 14 '24 15:06 codecov-notifications[bot]

Bundle Report

Changes will decrease total bundle size by 1.35kB :arrow_down:

Bundle name Size Change
gazebo-production-array-push 6.84MB 1.35kB :arrow_down:

codecov[bot] avatar Jun 14 '24 15:06 codecov[bot]

Bundle Report

Changes will decrease total bundle size by 1.35kB :arrow_down:

Bundle name Size Change
gazebo-staging-array-push 6.84MB 1.35kB :arrow_down:

codecov-staging[bot] avatar Jun 14 '24 15:06 codecov-staging[bot]

Closing as it's failing on an edge case. Will re-visit after another round of e2e testing.

rohitvinnakota-codecov avatar Jun 19 '24 16:06 rohitvinnakota-codecov