feedback
feedback copied to clipboard
SchemaStore definition for `comment.require_changes` is missing string type support
Description
I noticed that the JSON schema for Codecov hosted on SchemaStore.org incorrectly restricts the comment: require_changes field to only boolean values.
However, in valid Codecov configurations, this field can also accept string values (e.g., "coverage_drop").
Current Behavior
The schema currently defines the type as:
"require_changes": {
"type": "boolean"
}
Expected Behavior
The schema should allow require_changes to be either a boolean OR a string.
Impact
IDEs that rely on SchemaStore (such as PyCharm, VS Code, or IntelliJ) currently flag valid configurations as errors. For example, setting require_changes: "coverage_drop" triggers a "Type mismatch" warning, even though it is valid yaml/json for Codecov.
Reference
- Schema URL: https://www.schemastore.org/codecov.json
- Example of valid value:
require_changes: "coverage_drop"
Could you please update the source schema or submit a PR to SchemaStore to allow string types for this field?