feedback icon indicating copy to clipboard operation
feedback copied to clipboard

Duplicated codecov checks

Open A5rocks opened this issue 1 year ago • 4 comments

Reopening https://github.com/codecov/codecov-action/issues/1022, @thomasrockhu.

In https://github.com/python-trio/trio/pull/3040 for example, you can see a failed check and a successful check for the PR. If you check the commit specifically, there's duplicated versions of the checks but at least they are consistent.

Screenshot:

Image

https://github.com/python-trio/trio/pull/3029 is another that comes from a fork rather than from the same repository (hence doesn't duplicate regular github actions checks)


Edit: just note that we use codecov action v3 so this might be fixed? Though codecov action v4 led to weird coverage drops that were still there so we haven't switched.

A5rocks avatar Aug 02 '24 16:08 A5rocks

@A5rocks moving this to our feedback repo

thomasrockhu-codecov avatar Aug 02 '24 16:08 thomasrockhu-codecov

@drazisil-codecov do you mind taking a look why we are sending duplicate status checks?

thomasrockhu-codecov avatar Aug 02 '24 16:08 thomasrockhu-codecov

@thomasrockhu-codecov One is a check, the other is a status.

I suspect @A5rocks is seeing this bug https://github.com/codecov/engineering-team/issues/1967

drazisil-codecov avatar Aug 05 '24 13:08 drazisil-codecov

That seems very likely! https://github.com/python-trio/trio/pull/3051 is another PR that hit this just in case it helps.

A5rocks avatar Aug 05 '24 14:08 A5rocks