feedback icon indicating copy to clipboard operation
feedback copied to clipboard

Bug Report: User is shown the "enable component analytics" button when not logged in. Clicking results in an error

Open drazisil opened this issue 1 year ago • 1 comments

Describe the bug User is shown the "enable component analytics" button when not logged in. Clicking results in an error.

To Reproduce When user is not logged into Codecov On a repository That does not have component analytics enabled Navigate to https://<codecov_repo_url>/components Then click "enable component analytics button See error toast appear

Expected behavior Button is not shown to users when logged out

Screenshots The video is not corrupt, apparently GitHub/AWS does not like it. If you right-click and save, it is then playable.

https://github.com/user-attachments/assets/ac48c8d2-9a5b-4d57-a5e2-b0c18e9154f4

Updates

  • remove action button to only display for logged in org users
  • update toast messaging to show of left side of viewport

drazisil avatar Jul 26 '24 11:07 drazisil

We should not render components at all when the user is not logged in and there are no components to display.

eliatcodecov avatar Aug 07 '24 15:08 eliatcodecov