feedback icon indicating copy to clipboard operation
feedback copied to clipboard

We show both carried forward and uploaded sessions per flag in the uploads list

Open drazisil-codecov opened this issue 1 year ago • 5 comments

Describe the bug We show both carried forward and uploaded sessions per flag in the uploads list

To Reproduce Steps to reproduce the behavior:

  1. Go to https://app.codecov.io/gh/rustymotors/server/commit/3e76d6f676cba99b6ba9a849bb232c0c5f82a2aa
  2. View upload list

Expected behavior No carried forward entries for a flag that coverage was uploaded for on that commit.

drazisil-codecov avatar Apr 25 '24 15:04 drazisil-codecov

image

To be clear, I think it's showing both (as an example) the login flag, but also that it's being carried forward which seems conflicting.

thomasrockhu-codecov avatar Apr 30 '24 16:04 thomasrockhu-codecov

@drazisil-codecov I believe we spoke about this one and it should be a bug that we fix as I believe it's a regression. Did it make it into a bug sync/get assigned out at some point?

aj-codecov avatar May 08 '24 16:05 aj-codecov

@aj-codecov I was on vacation last week so I don't know. If not then it will be handled in next week's sync, assuming it's not assigned to anyone show it shows up :)

drazisil-codecov avatar May 08 '24 17:05 drazisil-codecov

https://github.com/codecov/internal-issues/issues/478

trent-codecov avatar May 15 '24 15:05 trent-codecov

The issue seems to be that it is duplicating the CF sessions on every upload. Plenty of details on the ticket linked.

trent-codecov avatar May 15 '24 15:05 trent-codecov

This is a bug on our end and not linked to the potential duplication with CF sessions as pointed above. PR for fix is in

adrian-codecov avatar May 30 '24 23:05 adrian-codecov

This is fixed - check the link in the original description to confirm

adrian-codecov avatar May 31 '24 17:05 adrian-codecov