feedback icon indicating copy to clipboard operation
feedback copied to clipboard

Commits from the merge queue should be also shown in the main branch

Open rohan-at-sentry opened this issue 1 year ago • 3 comments

Discussed in https://github.com/codecov/feedback/discussions/98

Originally posted by justinchuby October 13, 2023 We recently enabled codecov for the onnx/onnx repository. One of the things we discover is there is no "main" branch from the drop down:

image

Turns out the commits from the merge queue branch gh-readonly-queue/* are the same commits in main (e.g. https://app.codecov.io/gh/onnx/onnx/commit/b61d2a8ab7a7e60eb386a387c73e449dd3461b3e), but codecov does not show these commits as part of the main branch. This causes the portal to show no "main" branch at all for coverage data, which can be inconvenient and confusing.

rohan-at-sentry avatar Jan 08 '24 20:01 rohan-at-sentry

@justinchuby,

Codecov is not aware that a branch exists until coverage is uploaded from it. Is it possible for you to have your CI upload coverage again after the PR is merged?

@rohan-at-sentry ,

Additionally, Codecov does not currently support commits existing on multiple branches, see https://github.com/codecov/feedback/discussions/178

drazisil-codecov avatar Jan 09 '24 13:01 drazisil-codecov

Is it possible for you to have your CI upload coverage again after the PR is merged?

Do you have a recommended workflow for doing this?

justinchuby avatar Jan 09 '24 14:01 justinchuby

Is it possible for you to have your CI upload coverage again after the PR is merged?

Do you have a recommended workflow for doing this?

Depending on the CI workflow, you may be able to save the coverage report as an artifact somewhere. Then have a job that runs on main that:

  • Checks out the code (needed for the upload)
  • Downloads the coverage report
  • Runs the uploader to upload the coverage report under the new merged SHA

drazisil-codecov avatar Jan 09 '24 15:01 drazisil-codecov