codecov-python icon indicating copy to clipboard operation
codecov-python copied to clipboard

CircleCI: inconsistent args for build/job with codecov-python

Open blueyed opened this issue 7 years ago • 2 comments

https://github.com/codecov/codecov-bash/blob/7e6cfa3935aeb29de57298bda496dad27b24aa37/codecov#L541-L542

vs

https://github.com/codecov/codecov-python/blob/adc22c19f3e924cac15a7ee25edfb3a5b518bf7c/codecov/init.py#L345-L346

build=os.getenv('CIRCLE_BUILD_NUM') + "." + os.getenv('CIRCLE_NODE_INDEX'),
job=os.getenv('CIRCLE_BUILD_NUM') + "." + os.getenv('CIRCLE_NODE_INDEX'),

blueyed avatar Oct 29 '17 15:10 blueyed

This may be a bug in the python uploader, or it is handled differently. The bash uploader correctly handles CircleCI build URLs.

drazisil avatar Nov 18 '19 14:11 drazisil

@drazisil Ok. Can you move the issue there then? (This issue just documents / points out that they differ - I cannot say which is correct, but they should be the same)

blueyed avatar Nov 20 '19 04:11 blueyed