codecov-cli icon indicating copy to clipboard operation
codecov-cli copied to clipboard

codecovcli upload doesn't use correct codecov.yml

Open Ryang20718 opened this issue 1 year ago • 5 comments
trafficstars

codecov processing for patch coverage results doesn't seem to respect the actual codecov.yml file uploaded

example repro: https://github.com/Ryang20718/cflag/pull/17

However, the yaml file uploaded to codecov seems to be different from the one I had specified in my CI pipeline https://app.codecov.io/gh/Ryang20718/cflag/commit/72810cf6efb3243205bf6daf24c58af789f359c4

Image

Is there some sort of cache going on?

codecov upload run https://github.com/Ryang20718/cflag/actions/runs/11620035443/job/32360963982?pr=17

Ryang20718 avatar Oct 31 '24 21:10 Ryang20718

This is not exactly a bug, since we only use the uploaded codecov.yml for label analysis and still pull from the repo to get the one we use for coverage. (I think)

@aj-codecov / @rohan-at-sentry How do you want to handle this? Docs? Behavior change? Bug?

drazisil-codecov avatar Nov 01 '24 16:11 drazisil-codecov

@drazisil-codecov it would be great if there could be an option to overwrite the uploaded codecov.yml.

still pull from the repo

does that mean we have to modify the repo codecov.yml if we wanted to somehow work around this limitation for now?

Ryang20718 avatar Nov 01 '24 17:11 Ryang20718

does that mean we have to modify the repo codecov.yml if we wanted to somehow work around this limitation for now?

That is correct. It needs to be checked into GitHub on the SHA that you are uploading coverage for.

drazisil-codecov avatar Nov 01 '24 18:11 drazisil-codecov

it would be great if codecov_yml_path uses the codecov yml passed in rather than repo!

Ryang20718 avatar Nov 01 '24 19:11 Ryang20718

@Ryang20718 I'll mark this as a feature request as this has not been the case. I can see how it's a little misleading that we have an argument for codecov_yml_path, but as @drazisil-codecov mentioned, it is not used when uploading coverage. You will still need to follow the guidelines here

thomasrockhu-codecov avatar Nov 13 '24 00:11 thomasrockhu-codecov