Add "when" condition to upload results

[bonkey]

Replicate when: <<parameters.when>> from "Download Codecov Uploader" step in "Upload Coverage Results" and "Validate Codecov Uploader".

[thomasrockhu-codecov]

@bonkey can you explain your use case for this?

[bonkey]

When tests fail the build I'd like to be able to still upload tests results not only download CLI

[bonkey]

@thomasrockhu-codecov any update on that?

[quantizor]

We need this too

[quantizor]

@thomasrockhu-codecov can this be merged and released please, it's causing all sorts of annoyances due to some flaky unit tests in our setup. The coverage keeps changing because the reports for errored parallelism jobs don't get uploaded.

[quantizor]

@bonkey looks like this PR needs a rebase too

[quantizor]

@thomasrockhu-codecov /bump

[quantizor]

@thomasrockhu-codecov @drazisil-codecov someone please, this is a very annoying bug that is not possible to work around from userland

[thomasrockhu-codecov]

@quantizor sorry for the delay here. I've been working on a new release candidate for the Orb (5.0.0) which should remove the necessity for this PR. I'll leave this open in case that doesn't end up working for you.

[quantizor]

@quantizor sorry for the delay here. I've been working on a new release candidate for the Orb (5.0.0) which should remove the necessity for this PR. I'll leave this open in case that doesn't end up working for you.

@thomasrockhu-codecov Ah ok, interesting thank you. Is there an ETA? If not soon, would love to see this land to fix the immediate issue.

[thomasrockhu-codecov]

@quantizor hoping to get this out tomorrow!