codecov-api icon indicating copy to clipboard operation
codecov-api copied to clipboard

True Tokenless for BA and TA

Open nora-shap opened this issue 1 year ago • 2 comments

Purpose/Motivation

TT requires certain identifiers, BA and TA don't have the identifiers in their path, so I make custom methods to get the identifiers so that BA and TA can use TT.

Links to relevant tickets

https://github.com/codecov/engineering-team/issues/2298

nora-shap avatar Oct 10 '24 23:10 nora-shap

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

:white_check_mark: All tests successful. No failed tests found.

:loudspeaker: Thoughts on this report? Let us know!

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 96.26%. Comparing base (b62fc87) to head (56f613b). Report is 16 commits behind head on main.

:white_check_mark: All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #882   +/-   ##
=======================================
  Coverage   96.25%   96.26%           
=======================================
  Files         827      827           
  Lines       19090    19113   +23     
=======================================
+ Hits        18376    18399   +23     
  Misses        714      714           
Flag Coverage Δ
unit 92.53% <100.00%> (+<0.01%) :arrow_up:
unit-latest-uploader 92.53% <100.00%> (+<0.01%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Oct 10 '24 23:10 codecov[bot]

Test Failures Detected: Due to failing tests, we cannot provide coverage reports at this time.

:x: Failed Test Results:

Completed 2749 tests with 1 failed, 2742 passed and 6 skipped.

View the full list of failed tests

pytest

  • Class name: api.internal.tests.test_charts.TestChartQueryRunnerQuery
    Test name: test_query_aggregates_multiple_repository_totals

    self = <tests.test_charts.TestChartQueryRunnerQuery testMethod=test_query_aggregates_multiple_repository_totals>

    @override_settings(GITHUB_CLIENT_ID="3d44be0e772666136a13")
    def test_query_aggregates_multiple_repository_totals(self):
    query_runner = ChartQueryRunner(
    user=self.user,
    request_params={
    "owner_username": self.org.username,
    "service": self.org.service,
    "end_date": str(timezone.now()),
    "grouping_unit": "day",
    },
    )

    results = query_runner.run_query()

    assert len(results) == 1
    > assert results[0]["total_hits"] == 114
    E AssertionError: assert Decimal('14') == 114

    .../internal/tests/test_charts.py:564: AssertionError

codecov-public-qa[bot] avatar Oct 12 '24 01:10 codecov-public-qa[bot]

:x: 1 Tests Failed:

Tests completed Failed Passed Skipped
2743 1 2742 6
View the top 1 failed tests by shortest run time
api.internal.tests.test_charts.TestChartQueryRunnerQuery test_query_aggregates_multiple_repository_totals
Stack Traces | 0.072s run time
self = &lt;tests.test_charts.TestChartQueryRunnerQuery testMethod=test_query_aggregates_multiple_repository_totals&gt;

    @override_settings(GITHUB_CLIENT_ID="3d44be0e772666136a13")
    def test_query_aggregates_multiple_repository_totals(self):
        query_runner = ChartQueryRunner(
            user=self.user,
            request_params={
                "owner_username": self.org.username,
                "service": self.org.service,
                "end_date": str(timezone.now()),
                "grouping_unit": "day",
            },
        )
    
        results = query_runner.run_query()
    
        assert len(results) == 1
&gt;       assert results[0]["total_hits"] == 114
E       AssertionError: assert Decimal('14') == 114

.../internal/tests/test_charts.py:564: AssertionError

To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard

codecov-qa[bot] avatar Oct 12 '24 01:10 codecov-qa[bot]

:white_check_mark: All tests successful. No failed tests were found.

:mega: Thoughts on this report? Let Codecov know! | Powered by Codecov

github-actions[bot] avatar Nov 09 '24 00:11 github-actions[bot]