codecov-api icon indicating copy to clipboard operation
codecov-api copied to clipboard

Handle owner user potentially null in base interactor

Open RulaKhaled opened this issue 1 year ago • 9 comments

Purpose/Motivation

What is the feature? Why is this being done? If owner.user is null, we can't treat user as an anonymous user anymore. This is fixing to reset to anonymous user if user does not exist.

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

RulaKhaled avatar Aug 20 '24 09:08 RulaKhaled

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

:white_check_mark: All tests successful. No failed tests found.

:loudspeaker: Thoughts on this report? Let us know!

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 96.28%. Comparing base (dc30d7f) to head (0cbf23c). Report is 360 commits behind head on main.

:white_check_mark: All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #762      +/-   ##
==========================================
+ Coverage   96.14%   96.28%   +0.13%     
==========================================
  Files         814      841      +27     
  Lines       18441    24455    +6014     
==========================================
+ Hits        17731    23546    +5815     
- Misses        710      909     +199     
Flag Coverage Δ
unit 96.28% <ø> (+4.69%) :arrow_up:
unit-latest-uploader ?

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Aug 20 '24 09:08 codecov[bot]

@codecov-ai-reviewer test

RulaKhaled avatar Mar 26 '25 14:03 RulaKhaled

On it! Codecov is generating unit tests for this PR.

codecov-ai[bot] avatar Mar 26 '25 14:03 codecov-ai[bot]

@codecov-ai-reviewer test

RulaKhaled avatar Mar 26 '25 15:03 RulaKhaled

On it! Codecov is generating unit tests for this PR.

codecov-ai[bot] avatar Mar 26 '25 15:03 codecov-ai[bot]

@codecov-ai-reviewer test

RulaKhaled avatar Mar 26 '25 16:03 RulaKhaled

On it! Codecov is generating unit tests for this PR.

codecov-ai[bot] avatar Mar 26 '25 16:03 codecov-ai[bot]

:white_check_mark: Sentry found no issues in your recent changes :white_check_mark:

seer-by-sentry[bot] avatar Mar 26 '25 16:03 seer-by-sentry[bot]